Fix capacity nameplate for Battery OM costs in Fuel Cell#521
Fix capacity nameplate for Battery OM costs in Fuel Cell#521mjprilliman wants to merge 15 commits into
Conversation
Addresses SAM issue #485
Ensured voltage model inputs are disabled whenever iron flow battery is selected
Reading it up via pd.read_csv for eg will fail otherwise (without workarounds), and github can't display it because of that.
cpaulgilman
left a comment
There was a problem hiding this comment.
Thanks for finding this issue. The "Fuel Cell O and M Costs" UI form is only used for Fuel Cell configurations, so I think the checks for PV Battery and PVWatts Battery configurations can be omitted.
The O&M cost inputs for fuel cell are still a bit confusing because the replacement cost in $/kWh appears under the kW capacity column, but we can fix that later when we clean up the O&M variable names for #355.
sjanzou
left a comment
There was a problem hiding this comment.
Why are the but_report and request_feature files to be merged into patch?
Why are the epw and csv files to be merged into patch - are they part of new defaults?
Was the Sandia module library updated in this pull request?
| @@ -0,0 +1,31 @@ | |||
| --- | |||
There was a problem hiding this comment.
I accidentally branched off of develop originally then tried to change the branch to patch here. I may need to redo this. I'm not sure why bug_report and request_feature are here.
| equations{ 'om_capacity1_nameplate'} = define(){ | ||
| return ${batt_computed_bank_capacity}; | ||
| if( technology() == 'PV Battery' || technology() == 'Fuel Cell') | ||
| return ?${en_batt} |
There was a problem hiding this comment.
what about generic battery?
There was a problem hiding this comment.
@sjanzou This is on the Fuel Cell O and M Costs form that is only used for the Fuel Cell configurations, so no need for the configuration checks for other battery techs here.
-Changes capacity nameplate definition from kWh to kW for battery OM cost calculations
-Closes #520