Skip to content

Getem Cost GUI updates#2045

Merged
mjprilliman merged 33 commits into
developfrom
getem_costs
Apr 3, 2025
Merged

Getem Cost GUI updates#2045
mjprilliman merged 33 commits into
developfrom
getem_costs

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

-Update inputs, layout of pump costs category
-Move calculations for drilling, stimulation, pump costs to ssc
-Update call to cmod_geothermal_costs, update inputs and outputs
-Remove unused GUI equations
-Added option to specify which wells are stimulated

Corresponding branches and PRs:

ssc: getem_costs

ssc PR: NatLabRockies/ssc#1307

Unit Test Impact:

-need to run test script

Checklist

  • requires help revision and I added that label
  • adds, removes, modifies, or deletes variables in existing compute modules
  • adds a new compute module
  • changes defaults
  • I've tagged this PR to a milestone

Reminders- this section can be deleted

Checking for PySAM Incompatible API Changes.

When do the PySAM files need to be regenerated?

dguittet and others added 25 commits January 2, 2025 17:35
@mjprilliman mjprilliman added this to the SAM Spring 2025 Release milestone Mar 28, 2025
@mjprilliman mjprilliman requested a review from sjanzou March 28, 2025 21:24
@mjprilliman mjprilliman self-assigned this Mar 28, 2025
@mjprilliman mjprilliman changed the title Getem costs Getem Cost GUI updates Mar 28, 2025

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments

  1. Should the defaults be updated to the GETEM OM costs? e.g. Single Owner
    image

  2. Can you please resolved the test_results_win64.csv conflict with develop? Seems to be blocking the merge.

@sjanzou

sjanzou commented Apr 3, 2025

Copy link
Copy Markdown
Collaborator

Looks like there are issues with the IPH models running - e.g. Ubuntu
image

@mjprilliman mjprilliman merged commit 842d975 into develop Apr 3, 2025
@mjprilliman mjprilliman deleted the getem_costs branch April 3, 2025 23:32
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release geothermal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants