GETEM cost model, well count updates#1307
Merged
Merged
Conversation
debugging Flash technologies (EGS and hydro)
… track in ATB script
5 tasks
Pull Request Test Coverage Report for Build 14252355368Details
💛 - Coveralls |
sjanzou
approved these changes
Apr 2, 2025
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Everything running fine. Thanks for enduring this!
| double CGeothermalAnalyzer::RameyWellbore() | ||
| { | ||
| double alpharock = mo_geo_in.md_EGSThermalConductivity / (mo_geo_in.md_EGSRockDensity * mo_geo_in.md_EGSSpecificHeatConstant); | ||
| double alpharock = (mo_geo_in.md_EGSThermalConductivity) / (mo_geo_in.md_EGSRockDensity * mo_geo_in.md_EGSSpecificHeatConstant); |
Collaborator
There was a problem hiding this comment.
Did this make a change in the results? I hope not ;-)
| { | ||
| md_PumpWorkKW = md_NumberOfWells = md_NumberOfWellsInj = md_FlashBrineEffectiveness = md_PressureHPFlashPSI = md_PressureLPFlashPSI = 0.0; | ||
| md_GrossPlantOutputMW = md_GrossPowerMW = md_PlantBrineEffectiveness = md_PressureChangeAcrossReservoir = md_AverageReservoirTemperatureF = 0; | ||
| md_GrossPlantOutputMW = md_GrossPowerkW = md_PlantBrineEffectiveness = md_PressureChangeAcrossReservoir = md_AverageReservoirTemperatureF = 0; |
Collaborator
There was a problem hiding this comment.
Thanks for clearing up the units!
| static const char* getem_om_cost_calc_doc = | ||
| "Calculates the cable length in an ME array\\n" | ||
| static const char* getem_om_cost_calc_doc = | ||
| "Calculate annual O&M costs for geothermal power plants \\n\\n" |
Collaborator
There was a problem hiding this comment.
definitely more descriptive!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Update cost calculations
-Update well count calculations
-Move capex costs from GUI equations to cmod_geothermal_costs
-Closes #1247