Skip to content

Check for exact capacity match in capex tables#2044

Merged
mjprilliman merged 1 commit into
developfrom
capex-table-capacity-match
Mar 28, 2025
Merged

Check for exact capacity match in capex tables#2044
mjprilliman merged 1 commit into
developfrom
capex-table-capacity-match

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

-Check capex table calculations for situations where system capacity, battery capacity, fuel cell capacity, or land area matches the exact minimum or maximum scaling value in the tables.

[ include directions for reviewers if necessary- what or how should they test or review ]

Fixes #2014

Checklist

  • requires help revision and I added that label
  • adds, removes, modifies, or deletes variables in existing compute modules
  • adds a new compute module
  • changes defaults
  • I've tagged this PR to a milestone

Reminders- this section can be deleted

Checking for PySAM Incompatible API Changes.

When do the PySAM files need to be regenerated?

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed the problem, thank you!

@mjprilliman mjprilliman merged commit c90f6fb into develop Mar 28, 2025
@mjprilliman mjprilliman deleted the capex-table-capacity-match branch March 28, 2025 21:26
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release battery bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Battery capex table does not handle capacity greater than max table value

3 participants