Marine UI updates#2043
Merged
Merged
Conversation
Collaborator
|
The JPD file builds, but the pop up afterwards tells me to select the incorrect file "Humboldt Bay - DOE Reference" on the frequency of occurrence tab. The correct file is there and runs, so I think just the pop up needs to be corrected. |
Collaborator
Author
There's a mismatch issue in accessing the "Name" parameter as it is different from the file name. This may need to be re-factored a bit in the future. For now, I updated the callback to print out the file name in the output message. |
3 tasks
janinefreeman
approved these changes
Apr 2, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
-Update ME cost curves
-Fix modeled cost variables assigned to GUI equations rather than cmod_mhk_costs ouptuts
-Closes #1974
To review cost curves:
-See email with cost curve information
To review JPD file generation:
-Open ME Wave -LCOE calculator
-Click 'Create JPD from time series weather file(s)' button
-Use attached folder as weather files (or download weather files from API on SAM-private)
-Save output jpd
-Switch from 'Time series' to 'Frequency of occurence', check for output jpd file without callback errors
test_jpd.zip
Fixes #1974
Corresponding branches and PRs:
marine-cost-branches in ssc
SSC PR: NatLabRockies/ssc#1305
Unit Test Impact:
-Need to re-run test script
Checklist
Reminders- this section can be deleted
Checking for PySAM Incompatible API Changes.
When do the PySAM files need to be regenerated?