Retail rates grid export tests#2041
Conversation
sjanzou
left a comment
There was a problem hiding this comment.
The UI changes look good and ssc NatLabRockies/ssc#1303 changes look fine but the Mac runners are still failing. Are you still tweaking the tolerances?
I can't see the Mac failures due to the new mode of running things inside Python for test timing. Would you be willing to fix those tests (presumably be increasing tolerances) and then I can review the changes? |
|
I'm going to get the upload of the test log working in the event of failures. Right now here's the result of the test failure: https://github.com/NREL/ssc/actions/runs/14228462938/job/39873558687 |
This is helpful, thank you! (the latest results look a lot better!) |
sjanzou
left a comment
There was a problem hiding this comment.
Looks good, I am checking and updating ssc NatLabRockies/ssc#1303 on MacOS... Although the latest runners are passing and the Windows runners are failing...
Pull Request Template
Description
GUI side of NatLabRockies/ssc#1303, see that PR for details
Fixes # (#2040)
Corresponding branches and PRs:
NatLabRockies/ssc#1303 on SSC, develop other branches
Unit Test Impact:
New integration test on ssc to demonstrate grid export behavior (old test confirms battery grid export is 0 when checkbox is off)
Checklist