Skip to content

Remove Land Lease input form from BTM configurations#2003

Merged
cpaulgilman merged 4 commits into
patchfrom
sam-1996-remove-btm-land-lease
Feb 11, 2025
Merged

Remove Land Lease input form from BTM configurations#2003
cpaulgilman merged 4 commits into
patchfrom
sam-1996-remove-btm-land-lease

Conversation

@cpaulgilman

@cpaulgilman cpaulgilman commented Feb 7, 2025

Copy link
Copy Markdown
Collaborator

Remove "Operating Costs Land Lease" UI form from BTM configurations. Land lease only available for FOM financial models.

Remove land lease-related defaults from BTM configurations.

Test that all configurations load and simulate without error.

Fixes #1996

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.
  • This change requires updating the PySAM files via export_config. Please see When do the PySAM files need to be regenerated?

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman added bug financial Financial model UI User interface issue that applies across performance and financial models labels Feb 7, 2025
@cpaulgilman cpaulgilman added this to the 2024 Release Patch 1 milestone Feb 7, 2025
@cpaulgilman cpaulgilman self-assigned this Feb 7, 2025
Cashflow is_land_lease_config() function should work properly  now that land lease inputs removed from Hybrid BTM configurations.
@cpaulgilman cpaulgilman changed the title Remove Land Lease input form from BT configurations Remove Land Lease input form from BTM configurations Feb 7, 2025

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hybrids look good
BTM
image

FOM
image

cfline( 'cf_property_tax_expense', 0);
cfline( 'cf_insurance_expense', 0);
if ( is_land_lease_config() && strpos(technology(),'Hybrid') < 0 ) { cfline('cf_land_lease_expense', 0); } // hybrid land lease handled in cf_om_expenses() function
if ( is_land_lease_config() ) { cfline('cf_land_lease_expense', 0); } // hybrid land lease handled in cf_om_expenses() function

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing this...

@cpaulgilman cpaulgilman merged commit 22a010b into patch Feb 11, 2025
@cpaulgilman cpaulgilman deleted the sam-1996-remove-btm-land-lease branch February 11, 2025 16:10
@brtietz brtietz modified the milestones: 2024 Release Patch 1, SAM Spring 2025 Release Mar 7, 2025
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug financial Financial model UI User interface issue that applies across performance and financial models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Land lease cost inputs included in some BTM configurations

3 participants