Skip to content

Show cell type in PDF report for user-defined module option#2001

Merged
cpaulgilman merged 1 commit into
patchfrom
SAM-1853-pv-report-cell-type
Feb 5, 2025
Merged

Show cell type in PDF report for user-defined module option#2001
cpaulgilman merged 1 commit into
patchfrom
SAM-1853-pv-report-cell-type

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Show module type instead of number in PDF report for Detailed PV and PV Battery configurations.

Fixes #1853

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.
  • This change requires updating the PySAM files via export_config. Please see When do the PySAM files need to be regenerated?

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Modify report template for Detailed PV and PV Battery configurations
@cpaulgilman cpaulgilman added bug pv pvsam1, pvwatts, hcpv UI User interface issue that applies across performance and financial models labels Feb 4, 2025
@cpaulgilman cpaulgilman added this to the 2024 Release Patch 1 milestone Feb 4, 2025
@cpaulgilman cpaulgilman self-assigned this Feb 4, 2025
@cpaulgilman cpaulgilman merged commit 2c25399 into patch Feb 5, 2025
@cpaulgilman cpaulgilman deleted the SAM-1853-pv-report-cell-type branch February 5, 2025 16:09
@brtietz brtietz modified the milestones: 2024 Release Patch 1, SAM Spring 2025 Release Mar 7, 2025
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug pv pvsam1, pvwatts, hcpv UI User interface issue that applies across performance and financial models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PV PDF report module type for user specified optoin

3 participants