Conversation
mjprilliman
approved these changes
Oct 11, 2024
mjprilliman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Thanks for updating the API for recent changes!
|
|
||
| SAM_EXPORT double* SAM_Battery_Outputs_batt_dispatch_sched_mget(SAM_table ptr, int* nrows, int* ncols, SAM_error *err); | ||
|
|
||
| SAM_EXPORT double SAM_Battery_Outputs_batt_grid_charge_percent_nget(SAM_table ptr, SAM_error *err); |
Collaborator
There was a problem hiding this comment.
These outputs are from #1865 and NatLabRockies/ssc#1215. Sorry for not updating the autogen!
| }, | ||
| "PVLosses": { | ||
| "enable_subhourly_clipping": 0 | ||
| "enable_subhourly_clipping": 0, |
| return result; | ||
| } | ||
|
|
||
| SAM_EXPORT double* SAM_Pvwattsv8_Outputs_snow_cover_aget(SAM_table ptr, int* length, SAM_error *err){ |
Collaborator
There was a problem hiding this comment.
snow_cover added to pvwatts as part of NatLabRockies/ssc#1214.
cpaulgilman
approved these changes
Oct 11, 2024
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Configuration tree looks good without "Hybrid" appended to performance model names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SAM_1569 branch of SAM
