Skip to content

Standalone battery metrics#1865

Merged
mjprilliman merged 3 commits into
developfrom
standalone-batt-metrics
Oct 10, 2024
Merged

Standalone battery metrics#1865
mjprilliman merged 3 commits into
developfrom
standalone-batt-metrics

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Description

-Add year 1 standalone battery metrics to summary table

Fixes #1589

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added this to the SAM Fall 2024 Release milestone Oct 4, 2024
@mjprilliman mjprilliman self-assigned this Oct 4, 2024

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for adding the metrics.

@mjprilliman mjprilliman merged commit a985377 into develop Oct 10, 2024
@mjprilliman mjprilliman deleted the standalone-batt-metrics branch October 10, 2024 18:38
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release battery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set up battery charge from grid metrics for summary page of standalone battery

2 participants