Fix PV time series shading#1712
Merged
Merged
Conversation
Adjust size of 3d shade calculator window so "Save and close" is visible.
Collaborator
Author
For the shading database option, the beam shading loss is a DC loss, so is represented in the loss diagram in the "Module deviation from STC" category. There's a discussion about this here: NatLabRockies/ssc#205
I fixed that in the latest commit, and also made the 3D Shade Calculator window bigger so the "Save and close" tab is visible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




This fixes #1427 and #1678
Time series shading data should be correctly applied by 3D shade calculator for Detailed PV with up to 4 subarrays and 8 strings, and for PVWatts.
PVWatts shading data window should not show labels for strings/number of strings, and should not automatically select shading database option when time series data is imported or pasted.
File for testing: 3d-shade-test.zip
To Test:
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.