Update array sizing for battery environment temperature#1694
Conversation
array option instructions
|
@mjprilliman This fixes the error, but I'm not sure what the behavior is supposed to be. For a hybrid PVWatts-Wind-Battery system, I tested with 60-minute solar data and 15-minute wind data. Based on the UI text on the Battery Thermal UI form, I think the time series battery envirnoment temperature array should be for 15-minute data, but simulations run with no messages regardless of whether battery environment data is 60-minute or 15-minute data. What is the intended behavior? |
The intended behavior is to match the smallest time step, in your example the 15-minute wind data. This would only be relevant when the battery thermal time series array option is selected. I can't duplicate having the simulation work with a 60 minute array when testing a similar example on my side. |
cpaulgilman
left a comment
There was a problem hiding this comment.
Looks good.
I modifed SSC simulation message to help with this: NatLabRockies/ssc#1138
Pull Request Template
Description
-Update battery room temperature array sizing to take advantage of array.size == 1 handling already in ssc
-Add label instructions for users to size array for time series definition option.
Fixes #1691
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.