UI Messages for PTC with Battery Grid Charging#1542
Merged
Conversation
* Message box on Battery Dispatch page when grid charging is enabled with non-zero PTC. * Red text on Incentives page when PTC is non-zero with grid charging.
brtietz
requested changes
Nov 1, 2023
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
This works well for PV+Battery and standalone battery. When testing with PVWatts-Wind-FuellCell-Battery Single Owner, I don't see it appear in either location.
…Not sure why varinfo() returns null in some cases when variable is defined.
brtietz
approved these changes
Nov 3, 2023
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
Updates look great, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Add UI messages when PTC is enabled and battery is allowed to charge from grid. Should work for all FOM and BTM battery configurations including hybrids.
To test:
The battery dispatch page should display a pop-up window with a message. The Incentives page should show a red message near the PTC inputs.
Note that for manual dispatch, the pop-up window appears every time check "enable grid charging" for different periods -- a bit annoying, but I think acceptable.
Fixes #1507
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.