Skip to content

UI Messages for PTC with Battery Grid Charging#1542

Merged
cpaulgilman merged 5 commits into
developfrom
SAM1507_grid-charge-ptc-message
Nov 8, 2023
Merged

UI Messages for PTC with Battery Grid Charging#1542
cpaulgilman merged 5 commits into
developfrom
SAM1507_grid-charge-ptc-message

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

Add UI messages when PTC is enabled and battery is allowed to charge from grid. Should work for all FOM and BTM battery configurations including hybrids.

To test:

  1. Create a case with any battery configuration.
  2. On the incentives page set the state or federal PTC to a non-zero value and non-zero term. (Should work with single value or annual values.)
  3. On the Battery dispatch page, choose any dispatch option and enable grid charging.

The battery dispatch page should display a pop-up window with a message. The Incentives page should show a red message near the PTC inputs.

Note that for manual dispatch, the pop-up window appears every time check "enable grid charging" for different periods -- a bit annoying, but I think acceptable.

Fixes #1507

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

* Message box on Battery Dispatch page when grid charging is enabled with non-zero PTC.

* Red text on Incentives page when PTC is non-zero with grid charging.
@cpaulgilman cpaulgilman added this to the SAM Fall 2023 Release milestone Nov 1, 2023
@cpaulgilman cpaulgilman requested a review from brtietz November 1, 2023 22:50
@cpaulgilman cpaulgilman self-assigned this Nov 1, 2023

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well for PV+Battery and standalone battery. When testing with PVWatts-Wind-FuellCell-Battery Single Owner, I don't see it appear in either location.

@cpaulgilman cpaulgilman requested a review from brtietz November 2, 2023 18:00

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look great, thank you!

@cpaulgilman cpaulgilman merged commit 667d802 into develop Nov 8, 2023
@cpaulgilman cpaulgilman deleted the SAM1507_grid-charge-ptc-message branch November 8, 2023 23:51
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warn users about PTC and grid charging interactions

2 participants