Skip to content

Fix geothermal resource callback error#1517

Merged
cpaulgilman merged 2 commits into
developfrom
geothermal-ui-fix
Oct 26, 2023
Merged

Fix geothermal resource callback error#1517
cpaulgilman merged 2 commits into
developfrom
geothermal-ui-fix

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Fixes #1419

  • Check for cash flow financial model before updating analysis period default

  • Fix widget alignment for Mac

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Check for cash flow financial model before updating analysis period default

Fix widget alignment for Mac
@cpaulgilman cpaulgilman added this to the SAM Fall 2023 Release milestone Oct 23, 2023
@cpaulgilman cpaulgilman merged commit 8a8d2c7 into develop Oct 26, 2023
@cpaulgilman cpaulgilman deleted the geothermal-ui-fix branch October 26, 2023 17:12
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Geothermal defaults require Single Owner financial model

2 participants