Skip to content

Fix Send-to-Excel workbook to use cf_energy_sales instead of cf_energy_net#1501

Merged
cpaulgilman merged 4 commits into
developfrom
SAM_1473-send-excel-pbi
Oct 18, 2023
Merged

Fix Send-to-Excel workbook to use cf_energy_sales instead of cf_energy_net#1501
cpaulgilman merged 4 commits into
developfrom
SAM_1473-send-excel-pbi

Conversation

@cpaulgilman

@cpaulgilman cpaulgilman commented Oct 17, 2023

Copy link
Copy Markdown
Collaborator

Check all FOM Send-to-Excel with Equations workbooks to make sure that revenue, PBI, production O&M, and PTC are calculated from CF_energy_sales, which is calculated from positive values of gen.

Goes with NatLabRockies/ssc#1066

Fixes #1473

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@cpaulgilman cpaulgilman merged commit 932e008 into develop Oct 18, 2023
@cpaulgilman cpaulgilman deleted the SAM_1473-send-excel-pbi branch October 18, 2023 22:53
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Production Based Incentive references wrong cell for generation in send to excel with eqns for host-developer

2 participants