Skip to content

Update Fuel Cell FOM dispatch options#1492

Merged
mjprilliman merged 6 commits into
developfrom
fuelcell-fom-dispatch
Oct 13, 2023
Merged

Update Fuel Cell FOM dispatch options#1492
mjprilliman merged 6 commits into
developfrom
fuelcell-fom-dispatch

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Description

  • Remove load following dispatch option for FOM fuel cell dispatch
  • Make new UI form for Fuel Cell FOM dispatch
  • Update Fuel Cell and hybrid technologies for FOM fuel cell

Fixes #1486

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added this to the SAM Fall 2023 Release milestone Oct 10, 2023
@mjprilliman mjprilliman self-assigned this Oct 10, 2023

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good: Battery dispatch options are correct for FOM and BTM fuel cell configurations, including hybrids. Different dispatch options appear to be working for fuel cell configs.

Please change the "Fuel Cell Dispatch" UI form name to "Fuel Cell Dispatch BTM" to avoid confusion in the future, and to be consistent with the names for the "Battery Dispatch BTM" and "Battery Dispatch FOM" forms.

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. (Built and tested on Linux.)

@mjprilliman mjprilliman merged commit 7dad239 into develop Oct 13, 2023
@mjprilliman mjprilliman deleted the fuelcell-fom-dispatch branch October 13, 2023 21:33
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fuel cell dispatch to load option showing for Single Owner

2 participants