Skip to content

Fix unrequired variable default values to align with precheck changes#1467

Merged
mjprilliman merged 7 commits into
developfrom
SAM_1184
Sep 26, 2023
Merged

Fix unrequired variable default values to align with precheck changes#1467
mjprilliman merged 7 commits into
developfrom
SAM_1184

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Description

-Change default values with aren't required for simulation to fix errors from var table prechecks in NatLabRockies/ssc#1055
-Remove belpe model, input pages from standalone, generic residential battery configs
-Update hybrid defaults

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added this to the SAM Fall 2023 Release milestone Sep 26, 2023
@mjprilliman mjprilliman self-assigned this Sep 26, 2023

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this... we can revisit actual defaults for each configuration during the pre-release checklist.

@mjprilliman mjprilliman merged commit 88495c5 into develop Sep 26, 2023
@mjprilliman mjprilliman deleted the SAM_1184 branch September 26, 2023 21:38
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants