Skip to content

Improve PVsyst Meteo CSV to SAM CSV conversion#1430

Merged
cpaulgilman merged 1 commit into
developfrom
pvsyst-weather-file-conversion
Aug 17, 2023
Merged

Improve PVsyst Meteo CSV to SAM CSV conversion#1430
cpaulgilman merged 1 commit into
developfrom
pvsyst-weather-file-conversion

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator
  • Attempt to identify semicolon delimiters and display message that comma delimeters are required.
  • Update data column headings to match PVsyst documentation
  • Initialize Header and Data variables to avoid error.

Fix #1429

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

* Attempt to identify semicolon delimiters and display message that comma delimeters are required.
* Update data column headings to match PVsyst documentation
* Initialize Header and Data variables to avoid error.
@cpaulgilman cpaulgilman added this to the SAM Fall 2023 Release milestone Aug 12, 2023
@cpaulgilman cpaulgilman self-assigned this Aug 12, 2023
@cpaulgilman cpaulgilman merged commit 04f5e3b into develop Aug 17, 2023
@cpaulgilman cpaulgilman deleted the pvsyst-weather-file-conversion branch October 3, 2023 16:48
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weather file converter for PVsyst fails when format incorrect

1 participant