Skip to content

Loss adjustment widget fixes#1408

Merged
cpaulgilman merged 5 commits into
patchfrom
lossadj-widget-text
May 25, 2023
Merged

Loss adjustment widget fixes#1408
cpaulgilman merged 5 commits into
patchfrom
lossadj-widget-text

Conversation

@cpaulgilman

@cpaulgilman cpaulgilman commented May 24, 2023

Copy link
Copy Markdown
Collaborator

Description

Fixes #1407

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman
Add properties to example widgets for testing
40d8671
@cpaulgilman
Revise label text for lifetime data widgets
5b21605
@cpaulgilman
Revise default text for loss adjustment widget
876f4e5 
* Make default text match text in widget implementation to make it less confusing for UI developers
@cpaulgilman
Clean up loss adjustment widget
bcedd46 
* Automatically set descriptive text based on context
* Change "hourly" to "time series" in labels
* Add text describing how total loss is combined from constant, time series, custom periods
* Delete old commented-out code
* Change text that appears on UI form to not show average time series loss to avoid confusion
@cpaulgilman
Help revisions for adjustment factors
1c0952e
@cpaulgilman cpaulgilman added this to the 2022.11.21 Patch 2 milestone May 24, 2023
@cpaulgilman cpaulgilman requested review from sjanzou and tyneises May 24, 2023 22:51
@cpaulgilman cpaulgilman self-assigned this May 24, 2023
sjanzou
sjanzou approved these changes May 25, 2023
View reviewed changes

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works with ssc pull request 1028

@cpaulgilman cpaulgilman merged commit 18483ee into patch May 25, 2023
@cpaulgilman cpaulgilman deleted the lossadj-widget-text branch May 25, 2023 15:29
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjanzou sjanzou sjanzou approved these changes

@tyneises tyneises tyneises approved these changes

Assignees

@cpaulgilman cpaulgilman

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Milestone

2022.11.21 Patch 2

Development

Successfully merging this pull request may close these issues.

LossAdjustment Widget loss summary text misleading

3 participants

@cpaulgilman @sjanzou @tyneises