Skip to content

Fix loss diagram overlapping text#1393

Merged
cpaulgilman merged 4 commits into
patchfrom
fix-loss-diag
Apr 21, 2023
Merged

Fix loss diagram overlapping text#1393
cpaulgilman merged 4 commits into
patchfrom
fix-loss-diag

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Description

Fix loss diagram layout to avoid text extending beyond edge of diagram and overlapping with diagram borders.

image

image

File with extreme loss diagram examples for testing: loss-diag-test.zip

  • Diagram displays differently on different screens.
  • Right-click diagram image should not have overlap issues.
  • Diagram in PDF report should not have issues.

Fixes #1330

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Loss labels cut off at right

Baseline labels overlap border at bottom of diagram
@cpaulgilman cpaulgilman added this to the 2022.11.21 Patch 2 milestone Apr 21, 2023
@cpaulgilman cpaulgilman requested a review from mjprilliman April 21, 2023 17:55
@cpaulgilman cpaulgilman self-assigned this Apr 21, 2023
@cpaulgilman cpaulgilman merged commit 20573e4 into patch Apr 21, 2023
@cpaulgilman cpaulgilman deleted the fix-loss-diag branch April 21, 2023 22:44
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loss diagram labels extend beyond right border

2 participants