Skip to content

PV Design UI Improvements#1352

Merged
cpaulgilman merged 9 commits into
patchfrom
pv-inverter-voltages
Feb 14, 2023
Merged

PV Design UI Improvements#1352
cpaulgilman merged 9 commits into
patchfrom
pv-inverter-voltages

Conversation

@cpaulgilman

@cpaulgilman cpaulgilman commented Feb 11, 2023

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

For configurations with Detailed PV model, make inverter voltage ratings editable on System Design page so users can correct voltage ratings from CEC databsae that don't match manufacturer datasheets.

Improve PV sizing messages with more detailed suggestions:

image

Make multiple MPPT option more transparent:

image

To test:

  1. Create any Detailed PV or PV Battery case.
  2. On system design page, change inverter voltage ratings or number of modules per string, and note improved sizing messages. Test with multiple subarrays.
  3. Try changing inverter on Inverter page for different inverter models.
  4. Verify MPPT voltage clipping in results, note simulation message if array voltage exceeds inverter Vdc_max.
  5. Test with multiple MPPTs.

Fixes #1020

Partially addresses #209

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

* Remove duplicate `inv_snl_inverter_name` inverter library variable, was used in inverter_not_available_msg() function to check for missing library items, but this triggers on_change that prevents new error-checking of editable inverter voltage inputs on System Design page. Missing library items should only happen for users who edit the inverter library, which is a special case for advanced users.

* Add call to System Design page reset_inverter_voltages() function to update inputs on System Design page when inverter voltage ratings on Inverter page change.

* Remove duplicate inverter name variable from CEC Information section. Inverter name is above plot, consistent with Module page.

* Change variable label for module and inverter library from "module/inverter name" to "module/inverter library selection" for clarity.
@cpaulgilman cpaulgilman self-assigned this Feb 11, 2023
@cpaulgilman cpaulgilman added this to the 2022.11.21 Patch 1 milestone Feb 11, 2023

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice sizing message and popup when Vdc_max is low
image

Copy ratings from inverter page button is useful to reset

I am confused on the MPPT functionality - setting MPPT to 3 on inverter page and then clicking the Set MPPT inputs on the System Design page as follows:
image

Gives a simulation error:
image

project file attached
SAM_1352_Multiple_MPPTs.zip

What am I doing wrong?

@cpaulgilman

Copy link
Copy Markdown
Collaborator Author

@sjanzou I tried to improve the multiple MPPT messages to help guide users through confusing workflows -- this could use a UI redesign, but hopefully these messages work for now. Let me know if you find any other confusing workflows that are not handled clearly enough.

@cpaulgilman cpaulgilman requested a review from sjanzou February 14, 2023 06:12

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, 1 inverter for MPPT - I get that now!
Everything else looks good and the voltage settings are a great addition to test different scenarios

@cpaulgilman cpaulgilman merged commit 2723b05 into patch Feb 14, 2023
@cpaulgilman cpaulgilman deleted the pv-inverter-voltages branch February 14, 2023 19:42
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vdcmax from the CEC inverter list is not the inverter maximum DC voltage

2 participants