Removed Land based BOS, Offshore BOS models from Res and Com Wind#1169
Merged
Conversation
cpaulgilman
requested changes
Oct 4, 2022
Collaborator
There was a problem hiding this comment.
Two issues:
- I get a callback error for Wind / Residential when I choose Land-based installation and then check 'Go to balance-of-system...":
A solution might be to disable the button for res/com configurations.
- I don't think the "Offshore installation" option makes sense for Residential and Commercial financial models, so maybe set the radio button to "Land-based installation" and disable it for the res/com configurations?
Collaborator
Author
Was moving too fast on this issue. I like your proposed changes. Will implement and push again. |
edit label captions
cpaulgilman
approved these changes
Oct 7, 2022
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good now. Thanks for the changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
-Removed models from Residential and Commercial Wind as the models are built for utility scale wind
Fixes #1124
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.