Skip to content

PVWatts albedo UI fixes#1136

Merged
cpaulgilman merged 8 commits into
developfrom
albedo-pvwattsv8-ui
Oct 3, 2022
Merged

PVWatts albedo UI fixes#1136
cpaulgilman merged 8 commits into
developfrom
albedo-pvwattsv8-ui

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Fix #1079: Store PVWatts albedo as monthly values in UI for changing models from PVWatts to Detailed PV. Note that pvwattsv8 accepts single value, monthly values, or time series values for the albedo input, but UI only allows single value or time series from weather file.

Always enable albedo input. Disabling albedo input when "use weather file albedo" is checked is confusing because that albedo value is used when weather file does not have albedo data.

Clean up and align advanced PVWatts inputs.

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Fix #1079: Store PVWatts albedo as monthly values in UI for changing models from PVWatts to Detailed PV. Note that pvwattsv8 accepts single value, monthly values, or time series values for the albedo input, but UI only allows single value or time series from weather file.

Always enable albedo input. Disabling albedo input when "use weather file albedo" is checked is confusing because that albedo value is used when weather file does not have albedo data.

Clean up and align advanced PVWatts inputs.
@cpaulgilman cpaulgilman added the requires help revision Requires a Help revision before releasing public version label Aug 22, 2022
@cpaulgilman cpaulgilman added this to the SAM Fall 2022 Release milestone Aug 22, 2022
@cpaulgilman cpaulgilman reopened this Sep 30, 2022
@cpaulgilman cpaulgilman requested a review from sjanzou September 30, 2022 16:04

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue 1079 fixed with modifications here!

@cpaulgilman cpaulgilman merged commit 07d8f6e into develop Oct 3, 2022
@cpaulgilman cpaulgilman deleted the albedo-pvwattsv8-ui branch October 3, 2022 15:29
@cpaulgilman cpaulgilman removed the requires help revision Requires a Help revision before releasing public version label Oct 31, 2022
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PVWatts to Detailed PV Change Model...

2 participants