PVWatts albedo UI fixes#1136
Merged
Merged
Conversation
Fix #1079: Store PVWatts albedo as monthly values in UI for changing models from PVWatts to Detailed PV. Note that pvwattsv8 accepts single value, monthly values, or time series values for the albedo input, but UI only allows single value or time series from weather file. Always enable albedo input. Disabling albedo input when "use weather file albedo" is checked is confusing because that albedo value is used when weather file does not have albedo data. Clean up and align advanced PVWatts inputs.
sjanzou
approved these changes
Oct 1, 2022
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Issue 1079 fixed with modifications here!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1079: Store PVWatts albedo as monthly values in UI for changing models from PVWatts to Detailed PV. Note that pvwattsv8 accepts single value, monthly values, or time series values for the albedo input, but UI only allows single value or time series from weather file.
Always enable albedo input. Disabling albedo input when "use weather file albedo" is checked is confusing because that albedo value is used when weather file does not have albedo data.
Clean up and align advanced PVWatts inputs.
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.