Skip to content

Update nameplate capacity for standalone battery systems#1040

Merged
mjprilliman merged 12 commits into
patchfrom
SAM-1036-fix
May 23, 2022
Merged

Update nameplate capacity for standalone battery systems#1040
mjprilliman merged 12 commits into
patchfrom
SAM-1036-fix

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Description

-Change capacity nameplate (system_capacity) to maximum discharge power AC for standalone battery systems
-Affects basis for CBI calculations
-Adds ui variable to defaults for capacity payments

Fixes #1036

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added this to the 2021.12.02 Patch 2 milestone May 13, 2022
@mjprilliman mjprilliman self-assigned this May 13, 2022
@mjprilliman mjprilliman changed the title Sam 1036 fix Update nameplate capacity for standalone battery systems May 13, 2022

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for stand alone battery. Do we need to be more consistent with pv-battery and generic system? Those two still use the ambiguous "nameplate" language:

image

@cpaulgilman

Copy link
Copy Markdown
Collaborator

I agree with Brian: For PV-Battery and Generic-Battery, the variable label should be Battery maximum discharge power, MWac, and the last sentence of the UI text should be revised to read "The battery maximum discharge power is shown here for reference only." You can move the label about inflation to the left to make room.

Also, for the Standalone Battery configuration, I think the variable labels are likely to overlap on Mac and Linux, so maybe move the capacity payment amount and capacity payment escalation to the left to allow more vertical space between the variables.

mjprilliman and others added 3 commits May 16, 2022 09:03
show/hide of variables for batt and system capacity
* Label change to "Battery maximum discharge power"

* Format system nameplate calculated value to fixed with 3 decimals.

* Edit description to change label to battery maximum discharge power.

* Adjust vertical spacing between input boxes to be consistent with rest of UI.

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after my final tweaks to the UI.

@cpaulgilman cpaulgilman mentioned this pull request May 18, 2022
@cpaulgilman cpaulgilman added the requires help revision Requires a Help revision before releasing public version label May 20, 2022
@mjprilliman mjprilliman merged commit 163014f into patch May 23, 2022
@mjprilliman mjprilliman deleted the SAM-1036-fix branch May 23, 2022 17:35
@cpaulgilman cpaulgilman added added to release notes PR and/or issue has been added to release notes for a public release and removed requires help revision Requires a Help revision before releasing public version labels May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standalone battery nameplate reported as zero in Capacity Payments

3 participants