Fix #5355 - E+ 25.1.0: Wrap OutputControl:ResilienceSummaries #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
jmarrec
commented
Mar 12, 2025
Comment on lines
+91
to
+98
| ############################################################################### | ||
| # OUTPUTCONTROL:RESILIENCESUMMARIES # | ||
| ############################################################################### | ||
| if openstudio.VersionString(openstudio.openStudioVersion()) > openstudio.VersionString("3.9.0"): | ||
| output_table.addSummaryReport("ThermalResilienceSummary") | ||
| output_rs = model.getOutputControlResilienceSummaries() | ||
| output_rs.setHeatIndexAlgorithm("Extended") # Default is 'Simplified' | ||
|
|
Comment on lines
+101
to
+109
| ############################################################################### | ||
| # OUTPUTCONTROL:RESILIENCESUMMARIES # | ||
| ############################################################################### | ||
| if Gem::Version.new(OpenStudio.openStudioVersion) > Gem::Version.new('3.9.0') | ||
| output_table.addSummaryReport('ThermalResilienceSummary') | ||
| output_rs = model.getOutputControlResilienceSummaries | ||
| output_rs.setHeatIndexAlgorithm('Extended') # Default is 'Simplified' | ||
| end | ||
|
|
a1c2f7c to
8c1445c
Compare
joseph-robertson
approved these changes
Mar 12, 2025
| ############################################################################### | ||
| # OUTPUTCONTROL:RESILIENCESUMMARIES # | ||
| ############################################################################### | ||
| if openstudio.VersionString(openstudio.openStudioVersion()) > openstudio.VersionString("3.9.0"): |
Contributor
There was a problem hiding this comment.
This is added to an existing test, so we need the version comparison?
Contributor
Author
There was a problem hiding this comment.
yes. I don't have to have 3 new tests just for this dumb object, so added to an existing one.
| if openstudio.VersionString(openstudio.openStudioVersion()) > openstudio.VersionString("3.9.0"): | ||
| output_table.addSummaryReport("ThermalResilienceSummary") | ||
| output_rs = model.getOutputControlResilienceSummaries() | ||
| output_rs.setHeatIndexAlgorithm("Extended") # Default is 'Simplified' |
Contributor
There was a problem hiding this comment.
Does "Simplified" give something "new" in the summary report, or is that just the option to maintain the old behavior?
Contributor
Author
There was a problem hiding this comment.
Simplified gives the same as not having the object at all in your IDF. (= old)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Link to the Ubuntu 22.04 .deb installer to use for CI Testing. If not set, it will default to latest official release.
[OpenStudio Installer]: http://openstudio-ci-builds.s3-website-us-west-2.amazonaws.com/PR-5365/OpenStudio-3.10.0-alpha%2B51228c2c9b-Ubuntu-22.04-x86_64.deb
This Pull Request is concerning:
NewTest: a new test for a new model API class,Case 1: New test for a new model API class
Work Checklist
The following has been checked to ensure compliance with the guidelines:
autosize_hvac.rbto ensure the autosizedXXX values methods do workReview Checklist
# TODOadded tomodel_tests.rbout.oswhave been committedautosize_hvacas appropriateNewTest,TestFix,NewTestForExisting,OtherNewTest: addPendingOSMorAddedOSM