Four pipe beam #3031
Closed
Four pipe beam #3031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found out that I didn't do it for the Chiller:Electric:EIR new field I added recently (but which isn't implemented in the API currently anyways)
… chilled water loop, then the curves are mandatory, so making them non optional and removed the reset function for the curve. TODO: Need to assign default curves in the Ctor though...
…neIndepentVariable, I use a TableMultiVariableLookup with one independent variable
… and do it in all derived classes too.
Closed
9 tasks
Contributor
|
@jmarrec @kbenne says that there are now two separate prs, one that addresses const issues and one that adds this object. Based on his review we can merge the separate four pipe beam code but not yet the const stuff. Closing this pr, have the other prs already been opened? The four pipe object does not seem to have been merged yet |
Contributor
|
well. there are at least two different branches somewhere. Need to get those in PR form if they aren't already. |
Collaborator
Author
|
For future ref, I did split it in two:
|
This was referenced Sep 13, 2018
17 tasks
7 tasks
Merged
37 tasks
20 tasks
Merged
37 tasks
20 tasks
37 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrapped the object
AirTerminal:SingleDuct:ConstantVolume:FourPipeBeamin the SDK.CoilCoolingFourPipeBeamandCoilHeatingFourPipeBeamThe only thing I didn't fully test for is the OS App behavior. I merged latest develop in, in particular so I wouldn't have the crash on hvac tab #3023, but develop is broken so it won't build.
I have doubt about whether I need to override the
removemethod. I'll have to check that once develop is fixed.Other unplanned/side changes:
inletPort()methodsconst, hence the high number of files I touched.Review assignee should probably be @kbenne, time permitting.