Fixed Remaining CI Issues #5566
Merged
+140
−1,306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Test Results DashboardSummary
✅ All Tests Passed!📊 Test Run Information
|
added 17 commits
December 23, 2025 04:18
Explicitly set compiler=gcc, compiler.version=11, and compiler.libcxx=libstdc++11 in the conan install command. This ensures that the dependencies (boost, fmt, etc.) are built/used with the same compiler version as the system compiler (/usr/bin/c++) in the Ubuntu 22.04 environment, resolving undefined references to `_M_replace_cold`.
There was a problem hiding this comment.
Pull request overview
This pull request addresses installer package issues by fixing a CMake configuration typo and improving macOS DMG packaging with version information.
Key Changes:
- Fixed CMake variable typo from
CPACK_GENERATORStoCPACK_GENERATOR(correct CMake variable name) - Added OpenStudio version extraction and included it in the macOS DMG install prefix
- Restructured macOS artifact publishing into a separate job for better workflow organization
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vcpkg.json | Removed entire file (likely migrating away from vcpkg dependency management) |
| Jenkinsfile_develop_osx | Updated shared library reference to use osx_add_cache branch |
| .github/workflows/incremental-build.yml | Updated Docker image, build configuration, and test retry logic |
| .github/workflows/full-build.yml | Fixed CPACK_GENERATOR typo, added macOS version detection, separated macOS publishing job, improved test handling with retries |
| .github/workflows/full-build-vcpkg.yml | Removed entire vcpkg-based workflow file (consolidating to Conan-based builds) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
CI Results for a5f3015:
|
jmarrec
reviewed
Jan 6, 2026
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ended up being larger than I originally expected.
At a high level I focused on getting the github action workflow full build working across all platforms. I also fixed issues related the github action workflow incremental build.