Vcpkg Option #5565
Merged
Vcpkg Option #5565
+1,225
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@anchapin I don't get the point of this PR. Conan has been used so we have a cross platform way of pinning dependencies. If this is too slow it probably just means we're missing binaries on our artifactory (https://conan.openstudio.net) Deciding we want to change from conan to vcpkg is really not a light decision to make at all, and it should be weighted and discussed (I don't see this PR having a review). (This is also going to affect downstream projects such as a the OpenStudio Application) |
Collaborator
|
Ok I see that #5566 reverted this |
Collaborator
Author
|
I was just trying to test vcpkg in parallel hoping that it would speed up the builds on the free github runners but I ended up giving up trying to get it to work for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new github action workflow that utilizes vcpkg instead of Conan.
I'm hoping that this will speed up the Windows build.