Skip to content

Conversation

@DavidGoldwasser
Copy link
Collaborator

@DavidGoldwasser DavidGoldwasser commented Oct 28, 2025

prep for OS 3.11 testing with updated extension and standards gem. There will be at least one more update to standards gem before final OS 3.11.0

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@tijcolem tijcolem added the Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. label Oct 29, 2025
@DavidGoldwasser DavidGoldwasser added this to the OpenStudio SDK 3.11.0 milestone Oct 30, 2025
@jmarrec
Copy link
Collaborator

jmarrec commented Nov 14, 2025

@DavidGoldwasser Is there a reason not to merge this? Are you waiting on a standards gem update?

@jmarrec
Copy link
Collaborator

jmarrec commented Nov 14, 2025

Ok there are problems.

EmbeddedRuby_Test#test_embedded_gems:

SyntaxError: :/ruby/3.2.0/gems/openstudio-standards-0.8.4/lib/openstudio-standards/btap/costing/daylighting_sensor_control_costing.rb:8: invalid character property name {L}: /(?<=\p{L})(?=\d)/
    eval:255:in `eval'
    eval:255:in `require_embedded_absolute'
    eval:188:in `require'
    <internal::/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
    eval:272:in `require_relative'
    :/ruby/3.2.0/gems/openstudio-standards-0.8.4/lib/openstudio-standards.rb:116:in `<module:OpenstudioStandards>'
    :/ruby/3.2.0/gems/openstudio-standards-0.8.4/lib/openstudio-standards.rb:5:in `<main>'
    eval:255:in `eval'
    eval:255:in `require_embedded_absolute'
    eval:240:in `block in require_embedded'
    eval:234:in `each'
    eval:234:in `require_embedded'
    eval:209:in `rescue in require'
    eval:203:in `require'
    <internal::/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:85:in `require'

https://github.com/NREL/openstudio-standards/blob/5a81f4f55493dc92e3506ae923539c74659d4a67/lib/openstudio-standards/btap/costing/daylighting_sensor_control_costing.rb#L8

not the first time we have an issue with the Oniguruma regex engine in embedded ruby. This will require an openstudio-standards change.

@jmarrec
Copy link
Collaborator

jmarrec commented Nov 14, 2025

I'm confused cause this seems to work on my windows VM:

test.rb

standards_template = 'NECB2011'

standards_template = standards_template.gsub(/(?<=\p{L})(?=\d)/, ' ')
puts standards_template

openstudio test.rb


I'm seeing that CI on Ubuntu 24.04 fails to run test_embedded_ruby-embedded_gems, but it works fine on my machine as well..

@jmarrec
Copy link
Collaborator

jmarrec commented Nov 14, 2025

@jmarrec jmarrec force-pushed the v3.11.0-OS-gems-update branch from b7062d6 to 3a86687 Compare November 17, 2025 08:24
@jmarrec
Copy link
Collaborator

jmarrec commented Nov 17, 2025

…hance MeasureManagerServer tests for improved error handling and state verification
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

🧪 Test Results Dashboard

Summary

Metric Value
Total Tests 4148
Passed 4137
Failed 11
Errors 0
Skipped 0
Success Rate 99.7%
Generated 2025-11-20 00:37:04 UTC

⚠️ Minor Issues Detected

🔍 Failed Tests (11 failures)

Linux-c++ (11 failures)

BCLFixture.BCLMeasure_CTor_throw_invalid_xml.BCLFixture.BCLMeasure_CTor_throw_invalid_xml (run1)

Error Message:

Failed

Full Details:

No details available
OpenStudioCLI.Classic.test_measure_manager.OpenStudioCLI.Classic.test_measure_manager (run1)

Error Message:

Failed

Full Details:

No details available
CLITest-test_bundle-bundle.CLITest-test_bundle-bundle (run1)

Error Message:

Failed

Full Details:

No details available
CLITest-test_bundle-bundle_git.CLITest-test_bundle-bundle_git (run1)

Error Message:

Failed

Full Details:

No details available
CLITest-test_bundle-bundle_native_embedded.CLITest-test_bundle-bundle_native_embedded (run1)

Error Message:

Failed

Full Details:

No details available
CLITest-test_bundle-bundle.CLITest-test_bundle-bundle (run3)

Error Message:

Failed

Full Details:

No details available
CLITest-test_bundle-bundle_git.CLITest-test_bundle-bundle_git (run3)

Error Message:

Failed

Full Details:

No details available
CLITest-test_bundle-bundle_native_embedded.CLITest-test_bundle-bundle_native_embedded (run3)

Error Message:

Failed

Full Details:

No details available
CLITest-test_bundle-bundle.CLITest-test_bundle-bundle (run2)

Error Message:

Failed

Full Details:

No details available
CLITest-test_bundle-bundle_git.CLITest-test_bundle-bundle_git (run2)

Error Message:

Failed

Full Details:

No details available
CLITest-test_bundle-bundle_native_embedded.CLITest-test_bundle-bundle_native_embedded (run2)

Error Message:

Failed

Full Details:

No details available

📊 Test Run Information

Run XML File Status
run1 results.xml ✅ Found
run3 results.xml ✅ Found
run2 results.xml ✅ Found

…st handling

- Introduced .bundle/config for Bundler settings.
- Updated .gitignore to include .bundle/config.
- Added comprehensive test utility functions for CI and local development.
- Implemented retry logic for network-dependent bundle installs in tests.
- Enhanced CMake configuration to label network-dependent and flaky tests.
@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Nov 20, 2025

@jmarrec jmarrec merged commit 0b0d540 into develop Nov 20, 2025
5 of 6 checks passed
@jmarrec jmarrec deleted the v3.11.0-OS-gems-update branch November 20, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants