Skip to content

Conversation

@jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Jun 10, 2025

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: #1697 - Add a Ruby and Python tests for ThermochromicGlazing OpenStudio-resources#221
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp): Don't think it's needed
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec requested a review from joseph-robertson June 10, 2025 16:20
@jmarrec jmarrec self-assigned this Jun 10, 2025
@jmarrec jmarrec added severity - Normal Bug component - Model component - IDF Translation Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels Jun 10, 2025
@anchapin anchapin merged commit 5fce3a3 into develop Jun 10, 2025
3 of 6 checks passed
@jmarrec
Copy link
Collaborator Author

jmarrec commented Jun 11, 2025

@anchapin did you merge this by mistake? It has a failing cppcheck and Joe didn't have time to review it.

jmarrec added a commit that referenced this pull request Jun 11, 2025
@jmarrec jmarrec mentioned this pull request Jun 11, 2025
19 tasks
jmarrec added a commit that referenced this pull request Jun 11, 2025
jmarrec added a commit that referenced this pull request Jun 11, 2025
@anchapin
Copy link
Collaborator

@jmarrec sorry for that. I asked @tijcolem and he suggested to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component - IDF Translation component - Model Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. severity - Normal Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-wrap Thermochromic window model properly

4 participants