Skip to content

Remove Water Loop Type #11332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mitchute merged 6 commits into from
Nov 14, 2025
Merged

Remove Water Loop Type #11332

mitchute merged 6 commits into from
Nov 14, 2025

Conversation

@mjwitte
Copy link
Contributor

@mjwitte mjwitte commented Nov 13, 2025

Pull request overview

Remove the need for PlantLoop "Water Loop Type" field.

Description of the purpose of this PR

  • Change the logic for HeatPump:AirToWater so that it does not require the water loop type to identify the heating or cooling side of the heat pump.
  • Remove the special use field.

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mjwitte mjwitte added the DoNotPublish Includes changes that shouldn't be reported in the changelog label Nov 13, 2025
@jmarrec
Copy link
Contributor

jmarrec commented Nov 13, 2025 •
edited
Loading

472 - integration.PlantLoopHeatPump_EIR_AirSource_and_AWHP_cooling_only (Failed)

   ** Severe  ** Plant Component HeatPump:AirToWater:Heating called "TEST_AWHP" was not found on any plant loops.
   **   ~~~   ** Component, type="HeatPump:AirToWater:Heating", name="TEST_AWHP" was not found on any Branch.
   **   ~~~   ** Look for mistyped branch or component names/types.
   ** Severe  ** Equipment type=HEATPUMP:AIRTOWATER with Name=TEST_AWHP not found on PlantLoop=COOLING COIL LOAD LOOP.
   **  Fatal  ** GetOperationSchemeInput: Errors found getting inputs. Previous error(s) cause program termination.

First Severe, backtrace

(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 1.1
    frame #0: 0x000000011035467c libenergyplusapi.25.2.0.dylib`EnergyPlus::ShowSevereError(state=0x000000016fdfb710, ErrorMessage="Plant Component HeatPump:AirToWater:Heating called \"TEST_AWHP\" was not found on any plant loops.", OutUnit1= Has Value=false , OutUnit2= Has Value=false ) at UtilityRoutines.cc:927:14
  * frame #1: 0x000000010f1b2798 libenergyplusapi.25.2.0.dylib`EnergyPlus::PlantUtilities::ScanPlantLoopsForObject(state=0x000000016fdfb710, CompName="TEST_AWHP", CompType=HeatPumpAirToWaterHeating, plantLoc=0x000000016fdeb820, errFlag=0x000000016fdeb810, LowLimitTemp=Optional<const double> @ 0x000000016fdeb870, HighLimitTemp=Optional<const double> @ 0x000000016fdeb890, CountMatchPlantLoops=ObjexxFCL::Optional_int @ 0x000000016fdeb8b0, InletNodeNumber=ObjexxFCL::Optional_int_const @ 0x000000016fdeb8d0, SingleLoopSearch=ObjexxFCL::Optional_int_const @ 0x000000016fdeb8f0, suppressErrors=ObjexxFCL::Optional_bool_const @ 0x000000016fdeb910) at PlantUtilities.cc:1742:17
    frame #2: 0x000000010f0375b8 libenergyplusapi.25.2.0.dylib`EnergyPlus::PlantCondLoopOperation::LoadEquipList(state=0x000000016fdfb710, LoopNum=1, SchemeNum=1, ListNum=1, ErrorsFound=0x000000016fdedb90) at PlantCondLoopOperation.cc:1303:25
    frame #3: 0x000000010f015238 libenergyplusapi.25.2.0.dylib`EnergyPlus::PlantCondLoopOperation::FindRangeBasedOrUncontrolledInput(state=0x000000016fdfb710, CurrentModuleObject="PlantEquipmentOperation:CoolingLoad", NumSchemes=1, LoopNum=1, SchemeNum=1, ErrorsFound=0x000000016fdedb90) at PlantCondLoopOperation.cc:890:25
    frame #4: 0x000000010f01299c libenergyplusapi.25.2.0.dylib`EnergyPlus::PlantCondLoopOperation::GetOperationSchemeInput(state=0x000000016fdfb710) at PlantCondLoopOperation.cc:675:21
    frame #5: 0x000000010f00088c libenergyplusapi.25.2.0.dylib`EnergyPlus::PlantCondLoopOperation::InitLoadDistribution(state=0x000000016fdfb710, FirstHVACIteration=true) at PlantCondLoopOperation.cc:2567:13
    frame #6: 0x000000010ee4c948 libenergyplusapi.25.2.0.dylib`EnergyPlus::DataPlant::HalfLoopData::solve(this=0x000062100006a5d0, state=0x000000016fdfb710, FirstHVACIteration=true, ReSimOtherSideNeeded=0x000062100006acc0) at LoopSide.cc:107:13
    frame #7: 0x000000010ee6166c libenergyplusapi.25.2.0.dylib`EnergyPlus::PlantManager::ManagePlantLoops(state=0x000000016fdfb710, FirstHVACIteration=true, SimAirLoops=0x0000614000000ed8, SimZoneEquipment=0x0000614000000edb, SimNonZoneEquipment=0x0000614000000edc, SimPlantLoops=0x0000614000000eda, SimElecCircuits=0x0000614000000ed9) at PlantManager.cc:217:32
    frame #8: 0x000000010db430b8 libenergyplusapi.25.2.0.dylib`EnergyPlus::HVACManager::SimSelectedEquipment(state=0x000000016fdfb710, SimAirLoops=0x0000614000000ed8, SimZoneEquipment=0x0000614000000edb, SimNonZoneEquipment=0x0000614000000edc, SimPlantLoops=0x0000614000000eda, SimElecCircuits=0x0000614000000ed9, FirstHVACIteration=0x000000016fdf1cc0, LockPlantFlows=false) at HVACManager.cc:1834:9
    frame #9: 0x000000010db350c4 libenergyplusapi.25.2.0.dylib`EnergyPlus::HVACManager::SimHVAC(state=0x000000016fdfb710) at HVACManager.cc:860:5
    frame #10: 0x000000010db299e4 libenergyplusapi.25.2.0.dylib`EnergyPlus::HVACManager::ManageHVAC(state=0x000000016fdfb710) at HVACManager.cc:277:5
    frame #11: 0x000000010deb6a68 libenergyplusapi.25.2.0.dylib`EnergyPlus::HeatBalanceAirManager::CalcHeatBalanceAir(state=0x000000016fdfb710) at HeatBalanceAirManager.cc:4544:9
    frame #12: 0x000000010deb6568 libenergyplusapi.25.2.0.dylib`EnergyPlus::HeatBalanceAirManager::ManageAirHeatBalance(state=0x000000016fdfb710) at HeatBalanceAirManager.cc:158:5
    frame #13: 0x000000010e115e34 libenergyplusapi.25.2.0.dylib`EnergyPlus::HeatBalanceSurfaceManager::ManageSurfaceHeatBalance(state=0x000000016fdfb710) at HeatBalanceSurfaceManager.cc:179:5
    frame #14: 0x000000010e02c350 libenergyplusapi.25.2.0.dylib`EnergyPlus::HeatBalanceManager::ManageHeatBalance(state=0x000000016fdfb710) at HeatBalanceManager.cc:209:9
    frame #15: 0x000000010f8a35ac libenergyplusapi.25.2.0.dylib`EnergyPlus::SimulationManager::SetupSimulation(state=0x000000016fdfb710, ErrorsFound=0x000000016fdf9c80) at SimulationManager.cc:2007:13
    frame #16: 0x000000010f89b514 libenergyplusapi.25.2.0.dylib`EnergyPlus::SimulationManager::ManageSimulation(state=0x000000016fdfb710) at SimulationManager.cc:271:9
    frame #17: 0x000000010c1fe2bc libenergyplusapi.25.2.0.dylib`RunEnergyPlus(state=0x000000016fdfb710, filepath="") at EnergyPlusPgm.cc:423:9
    frame #18: 0x000000010c1fdeb4 libenergyplusapi.25.2.0.dylib`EnergyPlusPgm(args=size=8, filepath="") at EnergyPlusPgm.cc:242:12
    frame #19: 0x0000000100001eb4 energyplus-25.2.0`main(argc=8, argv=0x000000016fdfd638) at main.cc:60:12
    frame #20: 0x000000018f509d54 dyld`start + 7184

@mjwitte
Copy link
Contributor Author

mjwitte commented Nov 13, 2025

** Severe ** Plant Component HeatPump:AirToWater:Heating called "TEST_AWHP" was not found on any plant loops.

Working on a fix.

rraustad
rraustad reviewed Nov 13, 2025
View reviewed changes
src/EnergyPlus/PlantCondLoopOperation.cc
machineName,
state.dataPlnt->PlantLoop(LoopNum).Name));
ErrorsFound = true;
}
Copy link
Contributor

@rraustad rraustad Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope the user never hooks these up backwards. I'm not sure but I think the plant passes either a 0 or a non-zero load (+ or -). So maybe a one-time check on a non-zero load could help a user with dyslexia. + would be associated with heating and - for cooling.

Copy link
Collaborator

@mitchute mitchute Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rraustad do you want to suggest an addition to this, or do we go on without it.

Copy link
Contributor

@rraustad rraustad Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mitchute I think it would be extremely rare or never happen. A defect file would help identify if anything could be done. This is better than it was so move on without any other changes.

@jmarrec jmarrec mentioned this pull request Nov 13, 2025
Merged
19 tasks
@mitchute
Copy link
Collaborator

mitchute commented Nov 14, 2025

Thanks @mjwitte for the quick fix, and @rraustad and @jmarrec for the reviews. Merging.

@mitchute mitchute merged commit aa9338d into develop Nov 14, 2025
11 checks passed
@mitchute mitchute deleted the removeWaterLoopType branch November 14, 2025 03:14
jmarrec added a commit to NREL/OpenStudio that referenced this pull request Nov 14, 2025
@jmarrec
Remove "Water Loop Type" from ProposedE+.idd
fb97ea3 
NREL/EnergyPlus#11332
@mjwitte mjwitte added the IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) label Nov 14, 2025
anchapin pushed a commit to NREL/OpenStudio that referenced this pull request Nov 30, 2025
@jmarrec
Remove "Water Loop Type" from ProposedE+.idd
ce23ae4 
NREL/EnergyPlus#11332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mitchute mitchute mitchute left review comments

@rraustad rraustad rraustad left review comments

Assignees

No one assigned

Labels

DoNotPublish Includes changes that shouldn't be reported in the changelog IDDChange Code changes impact the IDD file (cannot be merged after IO freeze)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mjwitte @jmarrec @mitchute @rraustad @nrel-bot-2 @nrel-bot-2c