Pull request overview

• Fixes HVAC Sizing Simulation should be disabled if Plant Sizing is not active #10797

Description of the purpose of this PR

It was noticed that when in the SimulationControl object that a user says "Yes" for the Do HVAC Sizing Simulation for Sizing Periods field without having any Sizing:Plant objects in the input that a hard crash results which is undesirable.

Now, when the user sets this field to "Yes" without any Sizing:Plant objects, one of two things happen. If the Do Plant Sizing Calculation field is set to "No", this overrides the user input for Do HVAC Sizing Simulation for Sizing Periods field and a warning error is produced. If the Do Plant Sizing Calculation field is set to "Yes", EnergyPlus will produce a severe/error warning stating that at least one Sizing:Plant object must be entered or these fields should both be set to "No".

A new unit test verifying the correct severe/fatal error is being produced under the correct conditions (both "Yes" and no Sizing:Plant objects). In addition, the description of the Do HVAC Sizing Simulation for Sizing Periods field was enhanced in the Input Output Reference so that it is clear what is required of the user.

Pull Request Author

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs