New Feature Heat Pump sizing according to ACCA Manual S #11130
Conversation
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Common function used by all heat pump parent types
| this->UnitType, | ||
| this->Name, | ||
| HVAC::cAllCoilTypes(this->m_CoolingCoilType_Num))); | ||
| } |
There was a problem hiding this comment.
Added a safety (if not empty) for this last else, which includes multiple DXCoil types, so that this would not crash (as it did many time during development) and instead give an indication of what type of coil was missed so that coil type can be added.
|
|
| SysCoolingCapacity = sizingCoolingCapacity.size(state, TempSize, errorsFound); | ||
| SysCoolingLoad = finalSysSizing.SensCoolCap; | ||
| SysTotCoolingLoad = finalSysSizing.TotCoolCap; | ||
| SysLatCoolingLoad = SysTotCoolingLoad - SysCoolingLoad; |
There was a problem hiding this comment.
HP Sizing Method: Set airflow used for sizing (5902/5904), call cooling cap sizer to get capacity needed to meet load (5920), set capacity and load variables (5921 - 5923) (for reporting). Same for heating at 5925 - 5935. Then call the common function DataSizing::setHeatPumpSize (5937). Then set ZoneEqSizingData sizing variables for use during coil sizing (5938 - 5942). Reset DataFlowUsedForSizing, just in case (5943).
| } | ||
| } | ||
|
|
||
| // ACCA Manual S reporting |
There was a problem hiding this comment.
Wait for coils to size (e.g., call to SimDXCoil at line 5947) before setting up table report since we need SHR to calculate sensible and latent components of total capacity.
|
@Myoldmopar the failure for linux IntegrationCoverage ReleaseWithDebInfo seems odd since linux UnitTestCoverage ReleaseWithDebInfo passes. |
| \paragraph{Field: Minimum Outdoor Dry-Bulb Temperature for Compressor Operation}\label{field-minimum-outdoor-dry-bulb-temperature-for-compressor-operation-000} | ||
| \paragraph{Field: DX Heating Coil Sizing Ratio}\label{field-dx-heating-coil-sizing-ratio-0303} | ||
|
|
||
| \textbf{Deprecated field}. The Minimum Outdoor Dry-Bulb Temperature for Compressor Operation is now controlled by the \hyperref[coilcoolingdxmultispeed]{Coil:Cooling:DX:MultiSpeed} and \hyperref[coilheatingdxmultispeed]{Coil:Heating:DX:MultiSpeed} (if used) coil objects. |
There was a problem hiding this comment.
Deprecated field replaced with a new numeric field.
|
|
|
|
|
|
|
@rraustad @Myoldmopar it has been 42 days since this pull request was last updated. |
|
@rraustad expecting a build failure on this merge. I would have fixed it up myself, but the intent wasn't clear to me. Can you take a look? |
Ah, I forgot to go back and set |
|
|
…-Initial-Implementation
|
|
mitchute
left a comment
There was a problem hiding this comment.
Seems like everyone is done here. Merging.
Pull request overview
Description of the purpose of this PR
Included for the following Equipment Types when operating as heat pump with DX coil types:
Added new input for DX Heating Coil Sizing Ratio to:
New table: Heat Pump ACCA Manual S Report:
New column: added to DX Heating Coils - Heating to Cooling Capacity Sizing Ratio to report user input for heat pump equipment.
New test files:
IDFVersioinUpdater transition for MultiSpeedHeatPump.idf:
V25.1:
V25.2:
Typical differences in existing test files:
Pull Request Author
Reviewer