Skip to content

Conversation

@rraustad
Copy link
Contributor

@rraustad rraustad commented May 1, 2025

Pull request overview

  • New Feature Proposal for heat pump sizing

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@rraustad rraustad added the NewFeature Includes code to add a new feature to EnergyPlus label May 1, 2025
@nrel-bot-2
Copy link

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

@rraustad
Copy link
Contributor Author

rraustad commented Jun 4, 2025

See issue #11092

@nrel-bot-2c
Copy link

@rraustad @Myoldmopar it has been 29 days since this pull request was last updated.

@Myoldmopar
Copy link
Member

NFP and Design only, merging.

@Myoldmopar Myoldmopar merged commit 665be15 into develop Jul 16, 2025
@Myoldmopar Myoldmopar deleted the NFP-HeatPump-Coil-Sizing-Options branch July 16, 2025 19:19
@Myoldmopar Myoldmopar changed the title Heat Pump Sizing: New Feature Proposal and Design Document [decent_ci_skip] [actions skip] Heat Pump Sizing: New Feature Proposal and Design Document Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NewFeature Includes code to add a new feature to EnergyPlus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants