Fix new Parameter crash in R#1364
Merged
Merged
Conversation
- change the exposed Parameter constructor to SEXP type - add a validation function in the rcpp interface - update the error message in the rcpp-fims test
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1364 +/- ##
==========================================
- Coverage 89.61% 89.60% -0.02%
==========================================
Files 82 82
Lines 8352 8360 +8
Branches 580 585 +5
==========================================
+ Hits 7485 7491 +6
- Misses 840 844 +4
+ Partials 27 25 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Removes return statement in doxygen documentation for the check on the value of a Parameter.
Rohith-1717
pushed a commit
to Rohith-1717/FIMS
that referenced
this pull request
Apr 12, 2026
- change the exposed Parameter constructor to SEXP type - add a validation function in the rcpp interface - update the error message in the rcpp-fims test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the feature?
How have you implemented the solution?
*- change the exposed Parameter constructor to SEXP type
Does the PR impact any other area of the project, maybe another repo?
Instructions for code reviewer
👋Hello reviewer👋, thank you for taking the time to review this PR!
nit:(for nitpicking) as the comment type. For example,nit:I prefer using adata.frame()instead of amatrixbecause ...This PR is now ready to be merged.Checklist