Load order precedence fix for config files issue #223#959
Closed
Suchitha-Joseph wants to merge 1 commit intoNLog:devfrom
Closed
Load order precedence fix for config files issue #223#959Suchitha-Joseph wants to merge 1 commit intoNLog:devfrom
Suchitha-Joseph wants to merge 1 commit intoNLog:devfrom
Conversation
The load order precedence of config files in current version of NLog has a bug and does not follow the documentation. More specific config files, e.g. program-name.exe.nlog, should be used before using NLog.config.The method LogFactory.GetCandidateFileNames has been fixed to return the files in the correct order. The unit test file ConfigFileLocatorTests.cs has the test PrecedenceTest which has also been updated to match the same ordering.
Member
|
Thanks! We have to check if this is a breaking change and thus should be merged with NLog 5. |
Member
|
@snakefoot could you please help me fixing this one? |
Contributor
|
@304NotModified Created #3376 |
Member
|
Superseded by #3376 Thanks @Suchitha-Joseph |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The load order precedence of config files in current version of NLog has
a bug and does not follow the documentation. More specific config files,
e.g. program-name.exe.nlog, should be used before using NLog.config.The
method LogFactory.GetCandidateFileNames has been fixed to return the
files in the correct order. The unit test file ConfigFileLocatorTests.cs
has the test PrecedenceTest which has also been updated to match the
same ordering.
fixes #223
This change is