Skip to content

Scan for process specific nlog-config first#3376

Merged
304NotModified merged 1 commit intoNLog:devfrom
snakefoot:NLogConfigPrecendenceFix
May 7, 2019
Merged

Scan for process specific nlog-config first#3376
304NotModified merged 1 commit intoNLog:devfrom
snakefoot:NLogConfigPrecendenceFix

Conversation

@snakefoot
Copy link
Copy Markdown
Contributor

Resolves #223 (Updated version of #959)

@snakefoot snakefoot force-pushed the NLogConfigPrecendenceFix branch from 239bba7 to a5bf7d7 Compare May 6, 2019 22:31
@304NotModified 304NotModified added breaking behavior change Same API, different result enhancement Improvement on existing feature merge when passing labels May 6, 2019
@304NotModified
Copy link
Copy Markdown
Member

Great! Thanks!

@304NotModified
Copy link
Copy Markdown
Member

Travis: ConfigFileLocatorTests.cs(258,98): error CS1503: Argument 3: cannot convert from 'System.StringComparer' to 'System.StringComparison' [/home/travis/build/NLog/NLog/tests/NLog.UnitTests/NLog.UnitTests.csproj]
The

@snakefoot snakefoot force-pushed the NLogConfigPrecendenceFix branch from a5bf7d7 to f05fc5d Compare May 7, 2019 05:20
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3376 into dev will decrease coverage by <1%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##             dev   #3376    +/-   ##
======================================
- Coverage     81%     81%   -<1%     
======================================
  Files        343     343            
  Lines      27570   27570            
  Branches    3707    3707            
======================================
- Hits       22285   22280     -5     
- Misses      4210    4220    +10     
+ Partials    1075    1070     -5

@304NotModified 304NotModified merged commit e721f41 into NLog:dev May 7, 2019
@304NotModified
Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking behavior change Same API, different result enhancement Improvement on existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Load order (precedence) of config files is broken

3 participants