Skip to content

Extract NLog extensions to their own repository #5985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
snakefoot merged 1 commit into from
Sep 4, 2025
Merged

Extract NLog extensions to their own repository #5985

snakefoot merged 1 commit into from
Sep 4, 2025

Conversation

@snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Sep 3, 2025 •
edited
Loading

@snakefoot snakefoot added this to the 6.0 milestone Sep 3, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 3, 2025 •
edited
Loading

Walkthrough

Removed four legacy target projects (NLog.Database, NLog.Targets.ConcurrentFile, NLog.Targets.Mail, NLog.Targets.Network) and their project files, code, layouts, internal helpers, enums, and docs; updated build and test scripts to stop packaging and running tests for the removed components.

Changes

Cohort / File(s) Summary
Build & Test scripts
build.ps1, run-tests.ps1, appveyor.yml		 Removed packaging and test invocations for Database, Mail, Network, Trace, WebService, ConcurrentFile targets; removed MSSQL2019 init step in CI matrix. Remaining build flow and other packages/tests unchanged.
NLog.Database (entire project removed)
src/NLog.Database/...
src/NLog.Database/NLog.Database.csproj, src/NLog.Database/DatabaseTarget.cs, src/NLog.Database/DatabaseCommandInfo.cs, src/NLog.Database/DatabaseParameterInfo.cs, src/NLog.Database/DatabaseObjectPropertyInfo.cs, src/NLog.Database/Internal/*, src/NLog.Database/Properties/AssemblyInfo.cs, src/NLog.Database/README.md		 Deleted the Database target project, its DatabaseTarget and related public types, internal helpers, project/assembly metadata, and README.
NLog.Targets.ConcurrentFile (entire project removed)
src/NLog.Targets.ConcurrentFile/...
src/NLog.Targets.ConcurrentFile/NLog.Targets.ConcurrentFile.csproj, src/NLog.Targets.ConcurrentFile/FileAppenders/*, .../FileArchiveModes/*, .../Internal/*, ArchiveNumberingMode.cs, FileArchiveEveryPeriod.cs, FilePathKind.cs, IFileCompressor.cs, IArchiveFileCompressor.cs, Win32FileAttributes.cs, Properties/AssemblyInfo.cs, README.md		 Removed the legacy ConcurrentFile target, all appender implementations (single/multi-process, mutex, unix/windows), archive mode implementations, internal utilities (watchers, helpers, recyclers), interfaces/enums, project/assembly files, and docs.
NLog.Targets.Mail (entire project removed)
src/NLog.Targets.Mail/...
src/NLog.Targets.Mail/NLog.Targets.Mail.csproj, MailTarget.cs, ISmtpClient.cs, MySmtpClient.cs, SmtpAuthenticationMode.cs, Properties/AssemblyInfo.cs, README.md		 Deleted Mail target, SMTP abstractions/wrapper, authentication enum, project/assembly metadata, and README.
NLog.Targets.Network (entire project removed)
src/NLog.Targets.Network/...
src/NLog.Targets.Network/NLog.Targets.Network.csproj, Targets/*, Layouts/*, NetworkSenders/*, Internal/*, Properties/AssemblyInfo.cs, README.md		 Removed NetworkTarget and derivatives (Gelf/Splunk/Log4JXml targets), related layouts (GelfLayout, SyslogLayout/ enums, Log4JXmlEventLayout, SplunkLayout), network sender stack (TCP/UDP/HTTP, SSL proxies), factories/interfaces, internal helpers, public enums/event args, project/assembly files, and docs.

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~120+ minutes

Poem

I trimmed my garden of wires and wheels,
Packed up the nets, the mails, the deals.
Soft paws sweep targets from the lane,
Lighter hops across the plain.
Logs still thump—thump—clear and bright;
Fewer burrows, faster flight.
(_/)> 🧹✨

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@snakefoot
Copy link
Contributor Author

snakefoot commented Sep 3, 2025

Azure DevOps build-time dropped from 10mins to 7mins.

The builds should also become more stable since no dependency on SQL-server and network-communication.

@snakefoot snakefoot merged commit 55eaacb into NLog:dev Sep 4, 2025
6 checks passed
@snakefoot snakefoot mentioned this pull request Sep 4, 2025
Closed
13 tasks
@coderabbitai coderabbitai bot mentioned this pull request Sep 7, 2025
Merged
This was referenced Sep 11, 2025
Merged
Merged
Merged
Merged
Closed
Closed
Merged
Closed
Merged
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 12, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
@snakefoot snakefoot mentioned this pull request Sep 28, 2025
Merged
jcasale added a commit to jcasale/PSNLog that referenced this pull request Dec 17, 2025
@jcasale
Removes database and mail targets due to NLog/NLog#5985.
435b02a
jcasale added a commit to jcasale/PSNLog that referenced this pull request Dec 17, 2025
@jcasale
Removes database and mail targets due to NLog/NLog#5985.
07cfa62
jcasale added a commit to jcasale/PSNLog that referenced this pull request Dec 17, 2025
@jcasale
Removes database and mail targets due to NLog/NLog#5985.
71b52b3
jcasale added a commit to jcasale/PSNLog that referenced this pull request Dec 17, 2025
@jcasale
Removes database and mail targets due to NLog/NLog#5985.
7d529f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

build-config size/XXL

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

1 participant

@snakefoot