LoggingConfigurationParser - Extracted from XmlLoggingConfiguration + rule name for `<rule>` + logger attribute for filtering by snakefoot · Pull Request #2891 · NLog/NLog

snakefoot · 2018-08-31T23:37:19Z

Retry of #2624. Where most JSON hacks have been removed (Only Array remains). Means more effort has to be put into the JsonLoggingConfiguration (Handle reordering when dictionary etc.)

There is a little "hack" around logging-rules, where this behaves the old way, where name specifies logger-wildcard:

<logger name="hello" final="true" />

And this creates a logging rule that can be identified with the name and matches the specified logger-wildcard:

<rule name="myname" logger="hello" final="true" />

This change is

304NotModified

(Handle reordering when dictionary etc.)

I think the rule should be, don't use dictionaries when the ordering is important in JSON. A list with items with an "id" is more inline with the JSON standard then.

304NotModified · 2018-09-01T14:16:52Z

+            return false;
+        }
+
+        private object ParseArrayItemFromElement(Type elementType, ILoggingConfigurationSection element)


I think the name is a confusing here (and in more paths). Is a section or an element?

proposal: ILoggingConfigurationElement or ILoggingConfigurationItem

304NotModified · 2018-09-01T14:17:35Z

+        /// <summary>
+        /// Rule identifier to allow rule lookup
+        /// </summary>
+        public string RuleName { get; }


fixes #2394 isn't?

Yes. And now also added LoggingConfiguration.FindRuleByName and RemoveRuleByName. Together with a little unit-test to verify they work.

I've a question about this. Is this a new attribute in the XML? or can't be set it from the XML?

@snakefoot bump

Like I said. You should not use <logger> but instead <rule> . Just like <targets> and <target>.

<rules> <rule name="hello" logger="*" minlevel="Info" writeTo="logconsole" /> <rule name="world" logger="*" minlevel="Debug" writeTo="logfile" /> </rules>

Ofcourse you can continue to use <logger> but then you cannot specify the rule-name

ow I didn't got that!

Do you really think that's a good idea? I have to agree "name" was a bad name (no pun intended), but a lot of docs uses of course name=*

it sounds like writing a long and good post about this, but you've maybe noticed I don't like writings blogs/newposts ;) (#2626)

Seems that rule element is not added to NLog.Schema yet?

304NotModified · 2018-09-01T14:23:52Z

I think this is the right direction! :)

(PS doubting of ConfigurationParseBase for the abstract class)

snakefoot · 2018-09-01T22:41:42Z

I think the rule should be, don't use dictionaries when the ordering is important in JSON. A list with items with an "id" is more inline with the JSON standard then.

Can only agree. But there are some funny business. Ex variables-section should be parsed first. Same goes for default-target-parameters and default-wrapper in the targets-section. (Just like the default parser already helps with loading extensions first, and logging-rules last).

But anyway all that extra Json-specific logic is now hidden away in my homemade ExtensionLoggingConfiguration (Depends on Microsoft.Extensions.Configuration.Abstractions). It looks okay to me, and with can load Json-Files nicely with help from Microsoft.Extensions.Configuration.Json.

But if variables in the variables-section references other variables. Then it is very important that the variables are declared using array instead of using dictionary. Because there is no logic in my homemade config-parser to reorder variables to ensure variable-references have been pre-added.

codecov · 2018-09-01T22:59:38Z

Codecov Report

Merging #2891 into dev will decrease coverage by <1%.
The diff coverage is 80%.

@@          Coverage Diff           @@
##             dev   #2891    +/-   ##
======================================
- Coverage     81%     80%   -<1%     
======================================
  Files        327     328     +1     
  Lines      24687   24911   +224     
  Branches    3171    3226    +55     
======================================
+ Hits       19899   20006   +107     
- Misses      3924    3995    +71     
- Partials     864     910    +46

snakefoot · 2018-09-23T20:16:32Z

it sounds like writing a long and good post about this, but you've maybe noticted I don't like writings blogs/newposts

No need to write anything. You can already use <appender> or <target> and now you can use <logger> or <rule>

304NotModified · 2018-09-23T20:34:24Z

ok merged, thanks!

…Log#2891)

304NotModified · 2019-02-22T20:50:27Z

docs added to https://github.com/NLog/NLog/wiki/configuration-file#rules

304NotModified · 2019-05-23T18:58:53Z

This works now in NLog 4.6.4:

<logger name="hello" final="true" rulename="name1" />

Fresa · 2019-05-27T07:25:35Z

Is it really "rulename"? It looks like it parses "name":

NLog/src/NLog/Config/LoggingConfigurationParser.cs

Line 582 in 6a803cb

case "NAME":

snakefoot · 2019-05-27T07:40:45Z

Changes currently lives in a branch called release/4.6.4 At some point it will be merged to dev and master branch

304NotModified · 2019-05-27T18:11:36Z

See

NLog/src/NLog/Config/LoggingConfigurationParser.cs

Lines 593 to 594 in b83d37f

    
           case "RULENAME": 
        
               ruleName = childProperty.Value; // Legacy Style

snakefoot force-pushed the LoggingConfigurationReader branch 2 times, most recently from b17f81d to 3ef294f Compare September 1, 2018 07:17

snakefoot changed the title ~~LoggingConfigurationReader - Extracted from XmlLoggingConfiguration~~ LoggingConfigurationParser - Extracted from XmlLoggingConfiguration Sep 1, 2018

snakefoot changed the title ~~LoggingConfigurationParser - Extracted from XmlLoggingConfiguration~~ WIP: LoggingConfigurationParser - Extracted from XmlLoggingConfiguration Sep 1, 2018

304NotModified self-assigned this Sep 1, 2018

304NotModified reviewed Sep 1, 2018

View reviewed changes

304NotModified added feature refactoring labels Sep 1, 2018

snakefoot force-pushed the LoggingConfigurationReader branch from 3ef294f to 3e62691 Compare September 1, 2018 22:35

snakefoot force-pushed the LoggingConfigurationReader branch 3 times, most recently from 5d48006 to 4f9c22b Compare September 1, 2018 22:57

snakefoot changed the title ~~WIP: LoggingConfigurationParser - Extracted from XmlLoggingConfiguration~~ LoggingConfigurationParser - Extracted from XmlLoggingConfiguration Sep 1, 2018

LoggingConfigurationParser - Extracted from XmlLoggingConfiguration

fe40508

snakefoot force-pushed the LoggingConfigurationReader branch from 4f9c22b to fe40508 Compare September 1, 2018 23:07

This was referenced Sep 15, 2018

Configure InternalLogger.LogLevel to Off when loading NLog.config #2913

Closed

Added NLog.Extensions.Configuration for ${configsetting} for appsettings.json and others NLog/NLog.Extensions.Logging#245

Merged

304NotModified changed the title ~~LoggingConfigurationParser - Extracted from XmlLoggingConfiguration~~ LoggingConfigurationParser - Extracted from XmlLoggingConfiguration + rule name for <logger> Sep 18, 2018

304NotModified mentioned this pull request Sep 23, 2018

Invalid attribute values in the <NLog> element should not break logging & better attribute parsing order #2931

Merged

304NotModified changed the title ~~LoggingConfigurationParser - Extracted from XmlLoggingConfiguration + rule name for <logger>~~ LoggingConfigurationParser - Extracted from XmlLoggingConfiguration + rule name for <logger> + logger attribute for filtering Sep 23, 2018

304NotModified merged commit 650ea5d into NLog:dev Sep 23, 2018

304NotModified added this to the 4.6 milestone Sep 23, 2018

snakefoot added a commit to snakefoot/NLog that referenced this pull request Sep 24, 2018

LoggingConfigurationParser - Extracted from XmlLoggingConfiguration (N…

46c4dbf

…Log#2891)

snakefoot mentioned this pull request Sep 30, 2018

Support for RuleName property on a <Rule> (LoggingRule class) #2394

Closed

This was referenced Oct 7, 2018

Configure NLogProviderOptions from appsettings.json NLog/NLog.Extensions.Logging#248

Merged

Configure from JSON instead of XML #1588

Closed

snakefoot mentioned this pull request Oct 23, 2018

Support layout renderer in log level filters (e.g. minLevel, maxLevel) #1502

Closed

snakefoot added a commit to snakefoot/NLog that referenced this pull request Nov 4, 2018

LoggingConfigurationParser - Extracted from XmlLoggingConfiguration (N…

d5c3392

…Log#2891)

snakefoot mentioned this pull request Dec 26, 2018

Move NLog config into appsettings.json, or alternatively, add extension method for ConfigurationBuilder to load NLog config NLog/NLog.Extensions.Logging#29

Closed

snakefoot mentioned this pull request Jan 14, 2019

NLog 4.6 RTM todo #3080

Closed

304NotModified added the needs documentation on wiki label Feb 8, 2019

304NotModified added the documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) label Feb 22, 2019

snakefoot mentioned this pull request Mar 28, 2019

"Skipping unknown 'NLog' property" after update to 4.6 #3251

Closed

snakefoot mentioned this pull request May 7, 2019

Missing documentation on rules for NLog.config #3377

Closed

This was referenced May 22, 2019

Various XSD improvements (NLog.Schema package) #3409

Merged

Decide what to do with <logger> and <rule> #3420

Closed

snakefoot deleted the LoggingConfigurationReader branch April 4, 2020 13:05

snakefoot mentioned this pull request Nov 10, 2020

No programmatic support for rule "enabled "attribute #4167

Closed

Conversation

snakefoot commented Aug 31, 2018 • edited by 304NotModified Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

304NotModified left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

snakefoot Sep 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

304NotModified Sep 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qaqz111 Apr 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

304NotModified commented Sep 1, 2018

Uh oh!

snakefoot commented Sep 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

snakefoot commented Sep 23, 2018 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

304NotModified commented Sep 23, 2018

Uh oh!

304NotModified commented Feb 22, 2019

Uh oh!

304NotModified commented May 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fresa commented May 27, 2019

Uh oh!

snakefoot commented May 27, 2019 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

304NotModified commented May 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

snakefoot commented Aug 31, 2018 •

edited by 304NotModified

Loading

snakefoot Sep 1, 2018 •

edited

Loading

304NotModified Sep 23, 2018 •

edited

Loading

qaqz111 Apr 11, 2019 •

edited

Loading

snakefoot commented Sep 1, 2018 •

edited

Loading

codecov bot commented Sep 1, 2018 •

edited

Loading

snakefoot commented Sep 23, 2018 via email •

edited

Loading

304NotModified commented May 23, 2019 •

edited

Loading

snakefoot commented May 27, 2019 via email •

edited

Loading

304NotModified commented May 27, 2019 •

edited

Loading