Added return_esmpy_regrid_operator to regrids and regridc #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhassell
requested changes
Apr 24, 2024
Collaborator
davidhassell
left a comment
There was a problem hiding this comment.
Hi Matt - looks good - thanks for the quick turn around!
I've made a few style suggestions.
Also we need {{return_esmpy_regrid_operator: bool, optional}} to be fleshed out in cf/docstring/docstring.py, after this line would be a good spot - hopefully the formatting is clear enough ...
And we need a new test method in cf/test/test_regrid.py - just one that sets return_esmpy_regrid_operator=True in both regrids and regridc, and checks the type (self.assertIsInstance) of the returned object should suffice.
There's still time :)
Co-authored-by: David Hassell <davidhassell@users.noreply.github.com>
Co-authored-by: David Hassell <davidhassell@users.noreply.github.com>
Contributor
Author
|
How's this? |
davidhassell
approved these changes
Apr 25, 2024
Collaborator
davidhassell
left a comment
There was a problem hiding this comment.
Nicely done, Matt - thanks. I took it upon myself to do a bit of tidying, and shall merge it. You made it in to 3.16.2!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #766
Added return_esmpy_regrid_operator kwargs to field/regrids and field/regridc, so that users wanting to make use of the functionality offered by it can do so via regrids and regridc, without having to call the regrid worker function directly.
This is possibly my 2nd ever PR, so if I've done something stupid, please forgive me... xD
For example, see #767