[sui system] stricter metadata validation, cleanup#25792
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
| let validator = self | ||
| self | ||
| .validators | ||
| .get_validator_mut_with_verified_cap(&verified_cap, false /* include_candidate */); |
Contributor
There was a problem hiding this comment.
The old one was not including candidates here but I think now we do?
Contributor
Author
There was a problem hiding this comment.
This is not very explicit, but it will fail on verify_cap call if validator is not active or pending.
Contributor
There was a problem hiding this comment.
To be very explicit, you meant the transaction will fail on the previous line (line 431) where we check the cap belongs to an active or pending validator right? So a candidate won't even get to line 432.
Contributor
Author
There was a problem hiding this comment.
@emmazzz precisely, see the selector on the verify_cap method, it will abort if not found.
damirka
commented
Mar 11, 2026
crates/sui-framework/packages/sui-system/sources/sui_system_state_inner.move
Outdated
Show resolved
Hide resolved
crates/sui-framework/packages/sui-system/sources/sui_system_state_inner.move
Show resolved
Hide resolved
lxfind
reviewed
Mar 11, 2026
crates/sui-framework/packages/sui-system/sources/sui_system_state_inner.move
Outdated
Show resolved
Hide resolved
crates/sui-framework/packages/sui-system/sources/validator_set.move
Outdated
Show resolved
Hide resolved
3a24c5a to
f84d3ee
Compare
dariorussi
approved these changes
Mar 13, 2026
Contributor
dariorussi
left a comment
There was a problem hiding this comment.
thanks for doing this, let's put it in
manolisliolios
approved these changes
Mar 13, 2026
Contributor
manolisliolios
left a comment
There was a problem hiding this comment.
Looks great! Logic is so much easier to follow
damirka
added a commit
that referenced
this pull request
Mar 13, 2026
## Description - make metadata checks stricter - code reorganisation and cleanup - drastically improves testing of metadata ## Test plan - massive tests --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [x] Protocol: metadata hardening in Sui System - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] Indexing Framework:
16 tasks
dariorussi
pushed a commit
that referenced
this pull request
Mar 13, 2026
## Description - cherry pick of #25792 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [x] Protocol: metadata hardening in Sui System - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] Indexing Framework: ## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [x] Protocol: metadata hardening in Sui System - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] Indexing Framework:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test plan
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.