[graphql-alt] Add missing ZkLogin fields to match gRPC interface [4/n]#25696
[graphql-alt] Add missing ZkLogin fields to match gRPC interface [4/n]#25696tpham-mysten merged 2 commits intomainfrom
Conversation
Add missing ZkLogin fields to match gRPC interface [4/n]
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
amnn
left a comment
There was a problem hiding this comment.
I wonder whether it's worth just exposing this information as a JSON payload... That is how they are typically interacted with, all the values are scalars, it's fairly compact, if you want one of the fields you're likely to want all of the fields, and it means we avoid having to introduce many specialised types into the schema.
I'm referring specifically to inputs and jwk_id in this case.
Approving to unblock regardless, but let me know what you think.
|
I agree Separately, my feeling is this field won't be commonly queried, mostly by advanced clients who would benefit from the full type safety and selective field querying that the structured approach provides. The logic is already implemented and not hard to maintain. |
8e553bb to
a04e502
Compare
Yeah, that's fair -- I don't have a strong feeling on it. My main reason to do this was to avoid making people fetch every field they cared about from these types, because it's likely they would want all of them (and that would also if these fields are nested inside pages, it would have a multiplicative effect on the output nodes). |
Description
inputs,publicIdentifier, andjwkIdfields toZkLoginSignatureto match the gRPC interfaceTest plan
How did you test the new or updated feature?
cargo check -p sui-indexer-alt-graphqlStack
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.