[antithesis] randomize checkpoint split limit for reachability assert#25364
Merged
alex-mysten merged 3 commits intomainfrom Feb 25, 2026
Merged
[antithesis] randomize checkpoint split limit for reachability assert#25364alex-mysten merged 3 commits intomainfrom
alex-mysten merged 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 similar comments
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
e8f7169 to
6666f50
Compare
6666f50 to
6a43729
Compare
6a43729 to
c884bf8
Compare
c884bf8 to
fac24ec
Compare
fac24ec to
21d7e16
Compare
21d7e16 to
c6c12b0
Compare
2a1688a to
c9ad9da
Compare
c9ad9da to
b8aafc8
Compare
mystenmark
reviewed
Feb 20, 2026
| true | ||
| } else { | ||
| mysten_common::in_antithesis() | ||
| }; |
Contributor
There was a problem hiding this comment.
you can use mysten_common::in_test_configuration()
mystenmark
reviewed
Feb 20, 2026
| validator_metadata_verify_v2: bool, | ||
|
|
||
| #[serde(skip_serializing_if = "is_false")] | ||
| randomize_checkpoint_tx_limit_in_tests: bool, |
Contributor
There was a problem hiding this comment.
let's make this a catch-all flag, randomize_params_for_tests and then below we will use this as a signal to randomize anything that it makes sense to randomize - we'll probably add more things than just this
Contributor
Author
There was a problem hiding this comment.
I think these need to be individualized for anything that is an existing protocol config.
The reason I added this is because without this we do an antithesis upgrade test, we get a fork, because the max_txns_per_checkpoint would change mid-epoch.
If we generalize this protocol config, any additional randomization we add here would also fork antithesis, as the whole block is gated by one flag.
We could also not gate it, knowing that the only risk is potentially misleading antithesis upgrade forks when we introduce new randomization.
Contributor
There was a problem hiding this comment.
ok, good point, we can also revisit this later
048640f to
268dd72
Compare
mystenmark
approved these changes
Feb 24, 2026
b663564 to
1230db8
Compare
1230db8 to
09d0f12
Compare
jessiemongeon1
pushed a commit
to jessiemongeon1/sui
that referenced
this pull request
Mar 5, 2026
…MystenLabs#25364) ## Description Lower the checkpoint split limit so we can assert reachability ## Test plan [steka-antithesis-cp-split-reachability 3430e84 4.0h](https://mystenlabs.antithesis.com/report/ZxSVmPkRhggT8uE06sAPf24U/8wWUOHsk4BFMv0hjPDJnvSqARNjVXdKcd5HoRcnWlho.html?auth=v2.public.eyJuYmYiOiIyMDI2LTAyLTE3VDAwOjUzOjA4Ljc4NDkyNTIyMloiLCJzY29wZSI6eyJSZXBvcnRTY29wZVYxIjp7ImFzc2V0IjoiOHdXVU9Ic2s0QkZNdjBoalBESm52U3FBUk5qVlhkS2NkNUhvUmNuV2xoby5odG1sIiwicmVwb3J0X2lkIjoiWnhTVm1Qa1JoZ2dUOHVFMDZzQVBmMjRVIn19fR9cbuhCp8uVXZPngeTBo1OwukkBAKAo7isIOEjEtILTkScnDPETk6NupSkMUVxkdHaKYn_LFKTeDxg3xv1l6gk) [steka-antithesis-cp-split-reachability mainnet upgrade split-version 4.0h](https://mystenlabs.antithesis.com/report/8slJysoNBugHn_CwKruqbihm/UY_kqoRdK0Qlgz21DNY8u2dv5Dk_iGsQnDbUTfBf9fU.html?auth=v2.public.eyJzY29wZSI6eyJSZXBvcnRTY29wZVYxIjp7ImFzc2V0IjoiVVlfa3FvUmRLMFFsZ3oyMUROWTh1MmR2NURrX2lHc1FuRGJVVGZCZjlmVS5odG1sIiwicmVwb3J0X2lkIjoiOHNsSnlzb05CdWdIbl9Dd0tydXFiaWhtIn19LCJuYmYiOiIyMDI2LTAyLTE3VDAxOjE4OjI1Ljc4NTAxOTI1NVoifR7ITGuMFJFEytjMk7yCqfKaVN7zs_5tZYlGqFBUA9lSXdkNtJxLpc0c_2TXCEDdsXgaiGVzf1U5wirO7FekUQw) --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [x] Protocol: test only changes, no user impact - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] Indexing Framework:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Lower the checkpoint split limit so we can assert reachability
Test plan
steka-antithesis-cp-split-reachability 3430e844 4.0h
steka-antithesis-cp-split-reachability mainnet upgrade split-version 4.0h
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.