Sounds good with me. Need to fix the app version to 3.0 - we never released 3.0 to have a 3.0.1.

Yeah, did that. 3.0.0

I'm glad that I was able to make the version code contribution - see how easy it is now - and no need to edit the splashscreen... 😉

I have a comment in that the Application configuration data is still retained in a file ("~/.config/Mudlet/Mudlet 1.0.conf") at least on Linux (registry on Windows - I don't know?) because we use the following invocation in several (4?) places:

QSettings settings("Mudlet", "Mudlet 1.0");

Note that this is a single file alone in a single sub-directory of another sub-directory because the "mudlet-data" symbol link set up in main:main() is set to point to and the literal name used throughout the application is "~/.config/mudlet". Also, according to Qt Help for QFile:symlink() on Windows the linkname itself must end in ".lnk" which it doesn't seem to be, unless it happens automagically.

I've been loath to touch the values used to initalise each QSettings instance that because of losing the previous settings a user might have. However as we now use QCoreApplication::setApplicationName() and QCoreApplication::setOrganisationName() (both are set to "Mudlet") we could use the default version of the above (without the parentheses or the contents within) and then the file would change to be "~/.config/Mudlet/Mudlet.conf" at least on *nix builds and something similar in Windows (we'd have to also use QCoreApplication::setOrganisationDomain() to set THAT to "mudlet.org" for use on Mac builds). A simpler alternative would be to change all the usages of QSettings to be:

QSettings settings("mudlet", "mudlet");

then on platforms that store the data in a file it would be "~/.config/mudlet/mudlet.cong" i.e. "mudlet.conf" in the place where we store other mudlet data files: {seemingly including irc_nick and local.conf) and the irc_nick could be moved into the settings file anyhow...

OK, let's have this as another PR for post 3.0.

On Fri, Aug 29, 2014 at 12:35 AM, Stephen Lyons notifications@github.com
wrote:

I'm glad that I was able to make the version code contribution - see how
easy it is now - and no need to edit the splashscreen... [image: 😉]

I have a comment in that the Application configuration data is still
retained in a file ("~/.config/Mudlet/Mudlet 1.0.conf") at least on Linux
(registry on Windows - I don't know?) because we use the following
invocation in several (4?) places:

QSettings settings("Mudlet", "Mudlet 1.0");

Note that this is a single file alone in a single sub-directory of another
sub-directory because the "mudlet-data" symbol link set up in main:main()
is set to point to and the literal name used throughout the application is
"~/.config/mudlet". Also, according to Qt Help for QFile:symlink() on
Windows the linkname itself must end in ".lnk" which it doesn't seem to be,
unless it happens automagically.

I've been loath to touch the values used to initalise each QSettings
instance that because of losing the previous settings a user might have.
However as we now use QCoreApplication::setApplicationName() and
QCoreApplication::setOrganisationName() (both are set to "Mudlet") we could
use the default version of the above (without the parentheses or the
contents within) and then the file would change to be
"~/.config/Mudlet/Mudlet.conf" at least on *nix builds and something
similar in Windows (we'd have to also use
QCoreApplication::setOrganisationDomain() to set THAT to "mudlet.org" for
use on Mac builds). A simpler alternative would be to change all the usages
of QSettings to be:

QSettings settings("mudlet", "mudlet");

then on platforms that store the data in a file it would be
"~/.config/mudlet/mudlet.cong" i.e. "mudlet.conf" in the place where we
store other mudlet data files: {seemingly including irc_nick and
local.conf) and the irc_nick could be moved into the settings file anyhow...

—
Reply to this email directly or view it on GitHub
#99 (comment).