Implementing Stephens comments from #966#972
Merged
vadi2 merged 4 commits intoMudlet:developmentfrom Apr 28, 2017
Merged
Conversation
SlySven
approved these changes
Apr 27, 2017
src/TCommandLine.cpp
Outdated
| if( ke->modifiers() & Qt::ControlModifier ) | ||
| { | ||
| moveCursor(QTextCursor::Up, QTextCursor::MoveAnchor ); | ||
| ke->accept(); |
Member
There was a problem hiding this comment.
This ought to go outside the if(...) {...} as well. 😁
ahmedcharles
approved these changes
Apr 27, 2017
src/TCommandLine.cpp
Outdated
| , mpHost( pHost ) | ||
| , mpConsole( pConsole ) | ||
| , mSelectedText( "" ) | ||
| , mSelectedText( QString() ) |
Contributor
There was a problem hiding this comment.
This already is a QString so it can just be mSelectedText().
src/TCommandLine.cpp
Outdated
| ke->accept(); | ||
| return true; | ||
| } | ||
| break; |
Contributor
There was a problem hiding this comment.
You could move the return true; and ke->accept(); here.
| return true; | ||
| } | ||
| break; | ||
| return true; |
Contributor
There was a problem hiding this comment.
Can also move ke->accept().
vadi2
added a commit
to vadi2/Mudlet
that referenced
this pull request
Apr 28, 2017
They got lost in the merge conflicts that occured in Mudlet#972.
ahmedcharles
added a commit
that referenced
this pull request
Apr 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing Stephens review from #966.
@SlySven keep reviews on topic please! Will not be doing this again.
Tagging @Mudlet/core-cpp for review.