Fix: Modules not loading when reopening a profile#8739
Merged
vadi2 merged 1 commit intodevelopmentfrom Jan 4, 2026
Merged
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
|
@vadi2 I can confirm that this fixes the issue. Local modules load and save just fine. |
Member
Author
|
Cherrypicked into release-4.20 branch. |
vadi2
added a commit
that referenced
this pull request
Jan 4, 2026
#### Brief overview of PR changes/additions - Skip duplicate module detection during profile loading sequence - Add warning logs when module loading fails #### Motivation for adding to Mudlet PR #8039 introduced a check that blocks module installation if the module is already in `mInstalledModules`. During profile reopen, modules are pre-populated in `mInstalledModules` from the saved XML before `installModulesList()` runs, causing all modules to fail with "already installed" - silently, since the return value wasn't checked. #### Other info (issues closed, discussion etc) **Root cause:** The stale reference check added in #8039 didn't account for the profile loading path where `mInstalledModules` is populated before modules are actually loaded. **Test case:** 1. Create a new profile 2. Install a module (e.g., via Module Manager) 3. Close the profile 4. Reopen the profile 5. Verify module scripts/triggers/UI are present and functional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Motivation for adding to Mudlet
PR #8039 introduced a check that blocks module installation if the module is already in
mInstalledModules. During profile reopen, modules are pre-populated inmInstalledModulesfrom the saved XML beforeinstallModulesList()runs, causing all modules to fail with "already installed" - silently, since the return value wasn't checked.Other info (issues closed, discussion etc)
Root cause: The stale reference check added in #8039 didn't account for the profile loading path where
mInstalledModulesis populated before modules are actually loaded.Test case: