Fix table.update crash when merging tables#8704
Closed
vadi2 wants to merge 1 commit intodevelopmentfrom
Closed
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
ZookaOnGit
approved these changes
Dec 28, 2025
2 tasks
vadi2
added a commit
to ehussong/Mudlet
that referenced
this pull request
Jan 23, 2026
Only recurse when both source and destination are tables. Otherwise, just replace the value directly.
Member
Author
|
Closing in favour of #8751 which has test case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Fix
table.updatecrashing when the second table has a nested table at a key where the first table has a simple value.Motivation for adding to Mudlet
table.update({ x = 1 }, { x = { y = 2 } })would crash instead of working.Other info (issues closed, discussion etc)
Closes #8694