Add Lua tests on Github Windows build#7695
Merged
vadi2 merged 3 commits intoMudlet:developmentfrom Feb 8, 2025
Merged
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
Author
|
@vadi2 |
vadi2
reviewed
Feb 7, 2025
Member
vadi2
left a comment
There was a problem hiding this comment.
Nice work! It looks great in CI.
Could you double-check the console output still works locally? Latest development build shows this for me:
PS C:\Users\vadim.peretokin> C:\Mac\Home\Downloads\Mudlet-4.19.1-testing-9831acc1-windows-64\Mudlet.exe
PS C:\Users\vadim.peretokin> Discord integration loaded. Using functions from: "discord-rpc64.dll"
mudlet::setupConfig() INFO: using config dir: "C:/Users/vadim.peretokin/.config/mudlet"
main(...) INFO - setting QT_MEDIA_BACKEND enviromental variable to: "windows".
Got CLI profiles: QList()
No CLI profiles specified, checking environment variable
Environment MUDLET_PROFILES value: ""
mudlet::mudlet() INFO - 'windows11' has been detected as the style factory in use - no styling fixes applied.
"Mudlet self-test" doesn't have a valid icon
qt.gui.imageio: libpng warning: bKGD: invalid
While this PR is just this:
PS C:\Users\vadim.peretokin> C:\Mac\Home\Downloads\Mudlet-4.19.1-testing-pr7695-1c051940-windows-64\Mudlet.exe
PS C:\Users\vadim.peretokin>
Contributor
Author
|
Hm, You are right, In Powershell the #ifdef Q_OS_WINDOWS
if (AttachConsole(ATTACH_PARENT_PROCESS)) {
if (qgetenv("MSYSTEM").isNull()) {
// print stdout to console if Mudlet is started in a console in Windows
// credit to https://stackoverflow.com/a/41701133 for the workaround
freopen("CONOUT$", "w", stdout);
freopen("CONOUT$", "w", stderr);
} else {
// simply print qt logs into stdout and stderr if it's MSYS2
qInstallMessageHandler(windowsConsoleMessageHandler);
}
}
#endif Whats your opinion? |
Member
|
Ahh, interesting difference. Okay, lets try this! |
Contributor
Author
|
Check the latest build it seems fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Fixes #6688
Other info (issues closed, discussion etc)
/claim #6688