Infrastructure: add sentry crash reporting#7664
Closed
vadi2 wants to merge 95 commits intodevelopmentfrom
Closed
Conversation
Contributor
There was a problem hiding this comment.
PR Summary
Here's a summary of the key changes in this PR that adds Sentry crash reporting to Mudlet:
Adds Sentry crash reporting integration with user privacy controls and build-specific configurations:
- Added Sentry native SDK v0.7.17 integration with crashpad handler for crash reporting
- Implemented user-configurable crash reporting settings in preferences dialog for both release and testing builds
- Added debug symbol and source code uploading to sentry.io for better crash analysis
- Disabled IP address collection in sentry settings to protect user privacy
- Added conditional compilation guards to enable/disable Sentry features based on build type
Key implementation points:
- Crash reports are off by default for releases but enabled for testing builds
- Sentry integration is properly isolated behind USE_SENTRY compile flag
- Includes proper cleanup and initialization of Sentry resources
- Added GCC 11 compiler requirement for better C++20 support
- Implemented build system changes to handle debug symbols and crashpad handler
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
11 file(s) reviewed, 8 comment(s)
Edit PR Review Bot Settings | Greptile
Resolved merge conflicts in: - .github/workflows/build-mudlet.yml: Combined libcurl4-openssl-dev and libassimp-dev dependencies - CI/setup-windows-sdk.sh: Added both uasm and assimp packages - cmake/IncludeOptionalModule.cmake: Used development version with DEFAULT parameter - src/main.cpp: Kept Sentry integration code from HEAD branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Add sentry for reporting when crashes happen.
Motivation for adding to Mudlet
So we can tell when Mudlet crashes - and fix any such issues!
Other info (issues closed, discussion etc)
IP address collection has been disabled in sentry settings to protect privacy of those who upload a crash.
/claim #7126, fixes #7126.
This is a re-run of #7618 but from the Mudlet repository, enabling secrets and thus sentry upload.
This PR is still a work in progress. TODO: