Skip to content

Infrastructure: add sentry crash reporting#7618

Closed
vadi2 wants to merge 51 commits intoMudlet:developmentfrom
vadi2:add-sentry-crash-reporting
Closed

Infrastructure: add sentry crash reporting#7618
vadi2 wants to merge 51 commits intoMudlet:developmentfrom
vadi2:add-sentry-crash-reporting

Conversation

@vadi2
Copy link
Copy Markdown
Member

@vadi2 vadi2 commented Dec 29, 2024

Brief overview of PR changes/additions

Add sentry for reporting when crashes happen.

Motivation for adding to Mudlet

So we can tell when Mudlet crashes - and fix any such issues!

Other info (issues closed, discussion etc)

IP address collection has been disabled in sentry settings to protect privacy of those who upload a crash.

This PR is still a work in progress. TODO:

  • get Linux to report line #'s in stack traces reliably
  • add sentry integration into AppImages, enable it for testing/ptb/release builds
  • upload source code in Linux build
  • upload debug symbols for Mudlet and Luarocks .so's to sentry for Linux
  • add sentry integration for macOS and test
  • upload source code in macOS build (duplicate uploads for simplicity)
  • upload debug symbols for Mudlet and Luarocks .so's to sentry for macOS
  • add sentry integration into macOS packaging, enable it for testing/ptb/release builds
  • add sentry integration for windows mingw and test
  • upload source code in windows mingw build (duplicate uploads for simplicity)
  • add sentry integration into windows packaging, enable it for testing/ptb/release builds
  • upload debug symbols for Mudlet and Luarocks .so's to sentry for Windows

Info:
To copy crashpad_handler over to source, use this:

cp ./build/_deps/sentry-build/crashpad_build/handler/crashpad_handler build/src

To upload debug data for the Mudlet binary, use this:

sentry-cli debug-files upload -o mudlet -p mudlet --wait ./build/src/mudlet

@add-deployment-links
Copy link
Copy Markdown

add-deployment-links bot commented Dec 29, 2024

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@vadi2 vadi2 force-pushed the add-sentry-crash-reporting branch from 0d8e4e9 to 20bd9e2 Compare December 29, 2024 17:57
vadi2 and others added 24 commits January 14, 2025 19:14
@vadi2
Copy link
Copy Markdown
Member Author

vadi2 commented Jan 15, 2025

Closing in favour of #7664

@vadi2 vadi2 closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants